Restart schema and capability #411
Conversation
Introduce first config phase, "applied", in which a device is sent one or more inline payloads or URLs to retrieve. The device then applies the payloads.
| @@ -3,17 +3,17 @@ | |||
| "blobset": { | |||
| "blobs": { | |||
| "arbitrary_manufacturer_id": { | |||
There was a problem hiding this comment.
Believe I deleted this file and moved the test to more specific filename blobset...
There was a problem hiding this comment.
They are still in the master branch of faucetsdn -- https://github.com/faucetsdn/udmi/blob/master/tests/config.tests/applied.json
I can delete them, but they haven't been deleted as of yet.
| @@ -3,17 +3,17 @@ | |||
| "blobset": { | |||
| "blobs": { | |||
| "arbitrary_manufacturer_id": { | |||
| "phase": "applied", | |||
There was a problem hiding this comment.
Yes but now rename the file too
There was a problem hiding this comment.
I don't understand what you mean by "rename the file" -- so might need to wait until you submit the cleanup PR before any of this will make sense.
There was a problem hiding this comment.
The phase is now final not applied so
mv blobset_applied.json blobset_final.json
| @@ -3,7 +3,7 @@ | |||
| "blobset": { | |||
| "blobs": { | |||
| "_firmware_update": { | |||
| "phase": "applied", | |||
| "title": "System Blobsets", | ||
| "description": "Predefined system blobsets", | ||
| "enum": [ | ||
| "_iot_config" |
There was a problem hiding this comment.
So we can define _firmware_update etc in this enum, reference it with constants, but we aren't using it as a key filter (instead we have open regex on config_blobset.json:15 ) ?
There was a problem hiding this comment.
The enums are things that end up in constants in the code -- but I don't know how to make the schema match "this should be an enum or not start with _" -- There is theoretically a "propertyNames" field in the schema spec, but I can't get it to actually do anything so it's either not really implemented, or implemented in a way I don't expect!
pubber/bin/run
Outdated
|
|
||
| echo $! > $ROOT_DIR/.pubber.pid | ||
| while [[ $result == 5 ]]; do |
pubber/bin/run
Outdated
| wait | ||
| PUB_PID=$! | ||
|
|
||
| echo $PUB_PID > $ROOT_DIR/.pubber.pid |
There was a problem hiding this comment.
Where are we reading this?
| publishStateMessage(); | ||
| System.err.println("Restarting system with extreme prejudice."); | ||
| System.err.flush(); | ||
| System.exit(RESTART_EXIT_CODE); |
There was a problem hiding this comment.
Just checking -- JVM doesn't reserve any exit status for its own operation, does it?
There was a problem hiding this comment.
Unclear -- the docs out there are pretty sketchy. Seems like people suggest that it follows the standard BASH rules, which means <128 are internal, 128 + 32 are for Unix signals.... I'll map to 192 and call it a day!
| wait $PUB_PID || result=$? | ||
| done | ||
|
|
||
| echo Done with pubber run, exit code $result |
There was a problem hiding this comment.
If wait fails we won't know it versus the process exiting with status 0. Do you care?
If so you could assign wait
| @@ -3,17 +3,17 @@ | |||
| "blobset": { | |||
| "blobs": { | |||
| "arbitrary_manufacturer_id": { | |||
| "phase": "applied", | |||
There was a problem hiding this comment.
The phase is now final not applied so
mv blobset_applied.json blobset_final.json
No description provided.