Fix for disabled CI integration testing and endpoint sequence test

.github/workflows/testing.yml

@@ -109,8 +109,8 @@ jobs:
         run: |
           bin/test_sequencer $GCP_TARGET_PROJECT
           more /tmp/sequencer.out
-          diff -u /tmp/sequencer.out etc/sequencer.out && echo No sequencer.out diff
-          diff -u /tmp/generated.md docs/specs/sequences/generated.md && echo No generated.md diff
+          diff -u /tmp/sequencer.out etc/sequencer.out
+          diff -u /tmp/generated.md docs/specs/sequences/generated.md
       - name: telemetry validator
         env:
           GCP_TARGET_PROJECT: ${{ secrets.GCP_TARGET_PROJECT }}
@@ -119,7 +119,7 @@ jobs:
           bin/test_validator $GCP_TARGET_PROJECT
           more /tmp/validator.out
           echo Comparing test run results with golden file:
-          diff -u /tmp/validator.out etc/validator.out && echo No validator diff detected.
+          diff -u /tmp/validator.out etc/validator.out
       - name: output logs
         env:
           GCP_TARGET_PROJECT: ${{ secrets.GCP_TARGET_PROJECT }}

docs/specs/sequences/generated.md

@@ -72,8 +72,7 @@ Push endpoint config message to device that results in a connection error.
 
 1. Update config:
     * Add `blobset` = { "blobs": {  } }
-1. Wait for device tried endpoint config which resulted in connection error
-1. Test failed: timeout waiting for device tried endpoint config which resulted in connection error
+1. Wait for blobset entry config status is error
 
 ## extra_config
 

etc/sequencer.out

@@ -1,5 +1,6 @@
 RESULT pass broken_config Sequence complete
 RESULT pass device_config_acked Sequence complete
+RESULT pass endpoint_config_connection_error Sequence complete
 RESULT pass extra_config Sequence complete
 RESULT pass periodic_scan Sequence complete
 RESULT pass self_enumeration Sequence complete
@@ -9,4 +10,5 @@ RESULT pass system_min_loglevel Sequence complete
 RESULT pass valid_serial_no Sequence complete
 RESULT pass valid_serial_no Sequence complete
 RESULT pass valid_serial_no Sequence complete
+RESULT pass valid_serial_no Sequence complete
 RESULT skip writeback_states Missing 'invalid' target specification

validator/src/main/java/com/google/daq/mqtt/sequencer/SequenceRunner.java

@@ -98,7 +98,9 @@ public abstract class SequenceRunner {
   private static final File resultSummary;
   private static final IotReflectorClient client;
   private static final String VALIDATOR_CONFIG = "VALIDATOR_CONFIG";
-  private static final String CONFIG_PATH = System.getenv(VALIDATOR_CONFIG);
+  public static final String DEFAULT_CONFIG = "/tmp/validator_config.json";
+  private static final String CONFIG_PATH =
+      Objects.requireNonNullElse(System.getenv(VALIDATOR_CONFIG), DEFAULT_CONFIG);
   private static final Map<Class<?>, SubFolder> CLASS_SUBFOLDER_MAP = ImmutableMap.of(
       SystemEvent.class, SubFolder.SYSTEM,
       PointsetEvent.class, SubFolder.POINTSET,

validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/BlobsetSequences.java

@@ -21,25 +21,26 @@ public class BlobsetSequences extends SequenceRunner {
 
   private static final String ENDPOINT_CONFIG_CONNECTION_ERROR_PAYLOAD =
       "{ "
-      + "  \"protocol\": \"mqtt\",\n"
-      + "  \"client_id\": \"test_project/device\",\n"
-      + "  \"hostname\": \"localhost\"\n"
-      + "}";
+          + "  \"protocol\": \"mqtt\",\n"
+          + "  \"client_id\": \"test_project/device\",\n"
+          + "  \"hostname\": \"localhost\"\n"
+          + "}";
 
   @Test
   @Description("Push endpoint config message to device that results in a connection error.")
   public void endpoint_config_connection_error() {
     BlobBlobsetConfig config = new BlobBlobsetConfig();
     config.phase = BlobPhase.FINAL;
-    config.base64 = String.valueOf(
-        Base64.getEncoder().encode(ENDPOINT_CONFIG_CONNECTION_ERROR_PAYLOAD.getBytes()));
+    config.base64 = Base64.getEncoder()
+        .encodeToString(ENDPOINT_CONFIG_CONNECTION_ERROR_PAYLOAD.getBytes());
     config.content_type = "application/json";
     deviceConfig.blobset = new BlobsetConfig();
-    deviceConfig.blobset.blobs = new HashMap<String, BlobBlobsetConfig>();
+    deviceConfig.blobset.blobs = new HashMap<>();
     deviceConfig.blobset.blobs.put(SystemBlobsets.IOT_ENDPOINT_CONFIG.value(), config);
 
-    untilTrue("device tried endpoint config which resulted in connection error", () -> {
-      Entry stateStatus = deviceState.blobset.blobs.get(SystemBlobsets.IOT_ENDPOINT_CONFIG).status;
+    untilTrue("blobset entry config status is error", () -> {
+      Entry stateStatus = deviceState.blobset.blobs.get(
+          SystemBlobsets.IOT_ENDPOINT_CONFIG.value()).status;
       return stateStatus.category.equals(BLOBSET_BLOB_APPLY)
           && stateStatus.level == Level.ERROR.value();
     });