Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge buildings-iot fork to faucetsdn #473

Merged
merged 686 commits into from
Oct 12, 2022

Conversation

mspratt-biot
Copy link
Collaborator

Updates include displaying site and device validation messages in the UI. The webs Angular version has been bumped to version 14, and the Angular Social Login package has been bumped to the latest to accommodate the usage of the new GIS APIs.

naveenlakshmi and others added 30 commits May 3, 2022 14:20
fixed docker pulished issue in api
* Restructured the Cloud Function to make it easier to understand

* Enhancing implementation

* Fleshing out system messages

* Refactoring how we instantiate collection

* Re-ordering inputs to write function

* Adding basic test framework

* Adding test to call handleUdmiEvent

* Updating test to validate a spy

* Converting project to typescript

* Splitting into distinct purpose files and tests

* Adding tests and minor refactors

* Adding tests and minor refactors

* Adding tests and minor refactors

* reverting some changes to package.json

* reverting some changes to package.json

* Removing comments that are not relevant

* Adding build script to transpile the code into js

* Adding proper support for husky

* Reverting Changes to Readme

* Removing uneeded ignore
…portFilteringDeviceNamesMakesModelsEtc

faucetsdn#755 backend to support filtering device names makes models etc
* Restructured the Cloud Function to make it easier to understand

* Enhancing implementation

* Fleshing out system messages

* Refactoring how we instantiate collection

* Re-ordering inputs to write function

* Adding basic test framework

* Adding test to call handleUdmiEvent

* Updating test to validate a spy

* Converting project to typescript

* Splitting into distinct purpose files and tests

* Adding tests and minor refactors

* Adding tests and minor refactors

* Adding tests and minor refactors

* reverting some changes to package.json

* reverting some changes to package.json

* Removing comments that are not relevant

* Adding build script to transpile the code into js

* Adding proper support for husky

* Reverting Changes to Readme

* Removing uneeded ignore

* Quick refactor to get ready for pointset messages

* Adding refacotored code

* Removing old code

* Adding sample messages and cleaning arguments
@noursaidi
Copy link
Collaborator

This does not seem to have fixed the Google OAuth with new client IDs, unless I've done something wrong deploying the updates.

@mspratt-biot
Copy link
Collaborator Author

You deployed this branch?

@noursaidi
Copy link
Collaborator

Yes, checked it out and also cleared local docker cache.

I can try on a completely fresh machine/project too, just to confirm issue is not on my end

@mspratt-biot
Copy link
Collaborator Author

We could get together so I can see what's going on. I've confirmed locally this branch uses the latest libraries which don't cause this client id issue anymore.

@mspratt-biot
Copy link
Collaborator Author

I think there is an issue with the build passing, that's probably why the image is stuck on that last one. I'll take a look.

@mspratt-biot
Copy link
Collaborator Author

So just make sure the version of node is at least either v14.15, or v16.10. The latest angular-cli depends on this. That should then allow the build to complete.

@noursaidi
Copy link
Collaborator

@mspratt-biot thanks for your response. I confirm this fixed my issue with Google login. My issue was an angular CLI - I did have the right version of NPM installed, but seemed to run into some issue installing AngularCLI. Manually deleting the directory worked (but I then had to delete it again to rebuild)

npm ERR! code ENOTEMPTY
npm ERR! syscall rename
npm ERR! path /usr/local/lib/node_modules/@angular/cli
npm ERR! dest /usr/local/lib/node_modules/@angular/.cli-G39XYeT9
npm ERR! errno -66
npm ERR! ENOTEMPTY: directory not empty, rename '/usr/local/lib/node_modules/@angular/cli' -> '/usr/local/lib/node_modules/@angular/.cli-G39XYeT9'

@mspratt-biot
Copy link
Collaborator Author

Glad to hear!

@grafnu grafnu self-requested a review October 11, 2022 14:29
@grafnu grafnu merged commit ec4e7f6 into faucetsdn:master Oct 12, 2022
@mspratt-biot mspratt-biot deleted the MergeForkToFaucetsdn branch November 16, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants