Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify config and refactor pp #69

Merged
merged 8 commits into from
Aug 22, 2021
Merged

refactor: simplify config and refactor pp #69

merged 8 commits into from
Aug 22, 2021

Conversation

favonia
Copy link
Owner

@favonia favonia commented Aug 10, 2021

No description provided.

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #69 (fb764fc) into main (105a6e1) will increase coverage by 3.15%.
The diff coverage is 52.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   69.05%   72.21%   +3.15%     
==========================================
  Files          21       24       +3     
  Lines        1173     1292     +119     
==========================================
+ Hits          810      933     +123     
+ Misses        358      355       -3     
+ Partials        5        4       -1     
Flag Coverage Δ
unittests 72.21% <52.35%> (+3.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/ddns.go 0.00% <0.00%> (ø)
cmd/ip.go 0.00% <0.00%> (ø)
cmd/priviledges.go 0.00% <0.00%> (ø)
internal/api/fqdn.go 100.00% <ø> (ø)
internal/config/config.go 55.49% <22.38%> (+2.36%) ⬆️
internal/detector/http.go 82.22% <81.81%> (+0.40%) ⬆️
internal/api/cloudflare.go 100.00% <100.00%> (ø)
internal/config/env.go 100.00% <100.00%> (ø)
internal/detector/dns.go 96.22% <100.00%> (+0.03%) ⬆️
internal/detector/ip.go 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105a6e1...fb764fc. Read the comment docs.

@favonia favonia force-pushed the refactor-pp branch 2 times, most recently from 0b1509c to 9ed1c13 Compare August 10, 2021 14:54
@favonia favonia linked an issue Aug 22, 2021 that may be closed by this pull request
@favonia favonia merged commit 4154147 into main Aug 22, 2021
@favonia favonia deleted the refactor-pp branch August 22, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test pp and update existing tests in other packages with mocked pp
1 participant