Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for onProgress event. #60

Merged
merged 4 commits into from
Nov 8, 2021
Merged

Added support for onProgress event. #60

merged 4 commits into from
Nov 8, 2021

Conversation

DaddyFrosty
Copy link
Contributor

@DaddyFrosty DaddyFrosty commented Nov 8, 2021

Added a onProgress callback/option. Tested and works.


This change is Reviewable

@fawazahmed0
Copy link
Owner

Thanks

@fawazahmed0 fawazahmed0 merged commit adeedd6 into fawazahmed0:main Nov 8, 2021
fawazahmed0 added a commit that referenced this pull request Nov 8, 2021
This reverts commit adeedd6, reversing
changes made to 0e99763.
@fawazahmed0
Copy link
Owner

I reverted this PR, because for some reason onProgress was throwing some error

@DaddyFrosty
Copy link
Contributor Author

What's the error?

@fawazahmed0
Copy link
Owner

Here's the error

C:\Users\nawaz\Documents\GitHub\youtube-uploader\dist\upload.js:125
            videoJSON.onProgress(progress);
                      ^

TypeError: videoJSON.onProgress is not a function
    at C:\Users\nawaz\Documents\GitHub\youtube-uploader\dist\upload.js:125:23
    at Generator.next (<anonymous>)
    at fulfilled (C:\Users\nawaz\Documents\GitHub\youtube-uploader\dist\upload.js:5:58)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

@DaddyFrosty
Copy link
Contributor Author

Oh shit, when I went to bed I made a last change to send a 0% progress event upon starting the upload, and I forgot to make the if statement a block, and so it was calling code it shouldn't for a better explanation look at the changes but this should work.

@DaddyFrosty DaddyFrosty mentioned this pull request Nov 8, 2021
fawazahmed0 added a commit that referenced this pull request Nov 8, 2021
fawazahmed0 added a commit that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants