Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #60 #62

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Fixed #60 #62

merged 2 commits into from
Nov 8, 2021

Conversation

DaddyFrosty
Copy link
Contributor

@DaddyFrosty DaddyFrosty commented Nov 8, 2021

Fixed #60


This change is Reviewable

Oops...
@fawazahmed0
Copy link
Owner

npm run build gives me this error:


src/upload.ts:146:23 - error TS2769: No overload matches this call.
  Overload 1 of 2, '(intervalId: Timeout): void', gave the following error.
    Argument of type 'Timer | undefined' is not assignable to parameter of type 'Timeout'.
      Type 'undefined' is not assignable to type 'Timeout'.
  Overload 2 of 2, '(handle?: number | undefined): void', gave the following error.
    Argument of type 'Timer | undefined' is not assignable to parameter of type 'number | undefined'.
      Type 'Timer' is not assignable to type 'number'.

146         clearInterval(progressChecker)
                          ~~~~~~~~~~~~~~~



Found 1 error.

@DaddyFrosty
Copy link
Contributor Author

Seems like the type is broken, I've tested clearInterval with any in a sandbox so it should be fine.

@DaddyFrosty
Copy link
Contributor Author

and I tried compiling it, went fine using a clone of the repo, sorry for the waste of time in case this works.

@fawazahmed0
Copy link
Owner

working fine now

@fawazahmed0 fawazahmed0 merged commit 4563167 into fawazahmed0:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants