Subscribe doesn't register listener if no callback

[gabriel]

If you call @faye.subscribe("/channel/**") without a callback (block), then it doesn't get added to @channels[name], so unsubscribe doesn't work. This was the problem I was having yesterday. Sometimes I did use a block and sometimes not, which confused me.

Let me know if I can be more help here. I can write a spec but the way the specs are setup subscribe is always taking a block so...

[jcoglan]

I don't understand what problem this is supposed to fix. Can you provide an example, or write a spec that covers the change?

I don't think this would have any functional effect at all; all it does is that instead of returning early if callback.nil?, it loops over the names and does nothing on each iteration.

[gabriel]

Yeah I'll write a spec...

Look closer, the loop is setting @channels[name] ||= ..

On Wednesday, February 26, 2014, James Coglan notifications@github.com
wrote:

I don't understand what problem this is supposed to fix. Can you provide
an example, or write a spec that covers the change?

I don't think this would have any functional effect at all; all it does is
that instead of returning early if callback.nil?, it loops over the names
and does nothing on each iteration.

Reply to this email directly or view it on GitHubhttps://github.com//pull/282#issuecomment-36117079
.

[jcoglan]

The spec is a unit test for the behaviour you've added, but I still don't understand why it's needed. What problem is the Client exhibiting that necessitates this change?