Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test that the value in a Data.Var.Var doesn't get converted #435 #437

Closed
wants to merge 3 commits into from
Closed

test that the value in a Data.Var.Var doesn't get converted #435 #437

wants to merge 3 commits into from

Conversation

ryskajakub
Copy link
Contributor

This PR should fail because of the test intially.

@ryskajakub ryskajakub mentioned this pull request Jun 23, 2015
Closed
@ryskajakub ryskajakub force-pushed the i435b branch 2 times, most recently from 2446ffa to 7eb9dad Compare June 24, 2015 04:05
@ryskajakub
fay-base: Data.Var - wrap types having variables in Ptr faylang#435
3e12676 
Due to changing the default behaviour of treating data with type
containing a type variable, the Data.Var ffi functions are failing
during runtime.
@ryskajakub
Copy link
Contributor Author

Ok, so there are three builds:

  1. first build shows that the test fails with old code
  2. second build shows that the code fixes the test
  3. third build puts back the setting of travis to run random 20 tests

That should be it.

@bergmark bergmark closed this in cfed892 Jun 24, 2015
@bergmark
Copy link
Member

Thanks, shipped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryskajakub @bergmark