Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selector not building over context's selector when starting with operator #42

Closed
Delgan opened this issue Jun 11, 2016 · 0 comments
Closed

Selector not building over context's selector when starting with operator #42

Delgan opened this issue Jun 11, 2016 · 0 comments
Assignees
@Delgan

Comments

@Delgan
Copy link
Collaborator

Delgan commented Jun 11, 2016 •
edited
Loading

While querying a defined context with a selector starting with + or ~, the siblings elements of the context are not taken into account to perform the search, so the query returns nothing while it should according to jQuery.

This is the cause of the following bug in Cheerio: cheeriojs/cheerio#867
@Delgan Delgan self-assigned this Jun 11, 2016
@fb55 fb55 closed this as completed in 13fc8f3 Jul 4, 2016
fb55 pushed a commit that referenced this issue Oct 21, 2018
@Delgan @fb55
Add siblings elements if needed (#43)
6a654e6 
* Try to fix some indentation inconsistency
* Add unittests to spotlight issue #42
* Uncomment some tests and fix issue with selector
* Fix #42 by adding siblings elements if needed

The module was not able to select siblings elements for selector
starting with `+` or `~` because these siblings elements was not
present in the array passed to `searchFunc`.
@gajus gajus mentioned this issue Oct 31, 2018
Closed
@anchengjian anchengjian mentioned this issue Nov 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Delgan Delgan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Delgan