Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Improvements #3

Closed
ADDISON74 opened this issue Apr 10, 2021 · 6 comments
Closed

Small Improvements #3

ADDISON74 opened this issue Apr 10, 2021 · 6 comments

Comments

@ADDISON74
Copy link

First Change
Do we need the ID column? Let's say we note the ID's for some images we want to select and delete. But we can do the same thing using file name which is more intuitive for a human without noting too many information on a paper.

Second Change
200px for the image size is too big and a scrolling efforts is needed. I recommend 100px.

Third Changes

  • I would suggest adding a header for the last column at the right named Action. We keep the same format like in other sections in Magento.
  • Instead of adding a link on the image and open it in a new window you could insert on column Action, bellow Delete link a new link named Save. It is more elegant and intuitive. See bellow

snip

fballiano added a commit that referenced this issue Apr 10, 2021
@fballiano
Copy link
Owner

  1. not really but at the same time it's a way to recognize new/old images based on the ID. also, filename could by duplicated on different content_type_id so we'd have to use a double column key which I think it's not even possible in magento's grids (btw I'd still prefer to have the ID key like every other magento's model).
  2. mmm depends on the kind of images, for my customers it may be difficult to recognize a smaller image so I wouldn't go less than 200, at the same time we could make it configurable...
  3. header was added
  4. if I add the download action I think there should be a massDownload action, which may be challanging (big zip size, timeouts, how to delete the ZIP file after download) so I thought that it would be better not to have a download at all... anyways it's something easy to add

@fballiano
Copy link
Owner

I was trying to add the download action but, when there are multiple actions the column itself renders as combobox:
Schermata 2021-04-10 alle 23 27 36

which is extremely uncomfortable to use so that's a no.

then I tried add multiple action columns:
Schermata 2021-04-10 alle 23 29 52

but that it also ugly (and I'd remove the headers which don't make any sense in that case)

so.. mmmm I'm wondering what makes more sense

fballiano added a commit that referenced this issue Apr 10, 2021
@fballiano
Copy link
Owner

I created a rendered and it's now nice and working:

Schermata 2021-04-11 alle 00 49 18

I decided to keep the "delete" link as last cause I think it's the most used and easiest to click

@ADDISON74
Copy link
Author

Excellent job. After using ImaClean for almost 8 years I found a new flavor thanks to you.

When pressing [Cancella] link you should ask "Are you sure?" like in Mass Delete actions. I posted an issue for this.

@fballiano
Copy link
Owner

I've created #10 to remind me about the thumb size ;-)

@fballiano
Copy link
Owner

thumbnail size is now configurable ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants