consistentfying #1159
Merged
consistentfying #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiak
reviewed
Jul 14, 2017
src/containers/NibrsContainer.js
Outdated
| @@ -117,8 +117,7 @@ const NibrsContainer = ({ | |||
| {content} | |||
| {isReady && | |||
| <div className="serif italic fs-12"> | |||
| Source: Reported {nibrsTerm} data from {placeDisplay},{' '} | |||
| {nibrsFirstYear}–{until}. | |||
| Source: Reported {nibrsTerm} data from {placeDisplay}. | |||
There was a problem hiding this comment.
Let's go the other way and include the year range in all sources
There was a problem hiding this comment.
do you think it's important to have that in the source? I excluded so i didn't have to add that special nibrsFirstYear logic across files
There was a problem hiding this comment.
Ya, I see your point. This reduces the complexity and the year range is always specified in the header. In the case of the NIBRS container it also contains a sentence about when the entity first started reporting NIBRS.
added 4 commits
July 17, 2017 16:22
To be consistent with the other source texts (agency chart and NIBRS chart), removing the dates from the trend chart source text. It remains in the section's header and on the X axis
To make them more extensible (such as supplying a "size" prop or text) I made the common terms in Terms.js full fledged react components. I used children instead of a text prop to maintain consistency with how the underlying Term component works
Remove book.svg because it wasn't being used for anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: https://github.com/18F/crime-data-frontend/issues/1030
a bunch of small consistent-fying