Add legacy rape definition change indicator for 2013 #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendansudol
reviewed
Mar 8, 2017
src/components/TrendChart.js
Outdated
| @@ -166,6 +191,27 @@ class TrendChart extends React.Component { | |||
| onMouseMove={this.rememberValue} | |||
| onMouseOut={this.forgetValue} | |||
| /> | |||
| {(timeTo >= 2013 && crime === 'rape') && ( | |||
| <g> | |||
There was a problem hiding this comment.
i think it might be easier to transform this g element to the proper spot, and then simply place the rect and text relative to that (so that we only need to do that x(new Date(2013-01-01) in one spot)
brendansudol
reviewed
Mar 8, 2017
src/components/TrendChart.js
Outdated
| @@ -166,6 +191,27 @@ class TrendChart extends React.Component { | |||
| onMouseMove={this.rememberValue} | |||
| onMouseOut={this.forgetValue} | |||
| /> | |||
| {(timeTo >= 2013 && crime === 'rape') && ( | |||
| <g> | |||
| <g> | |||
There was a problem hiding this comment.
don't think this g is necessary
jeremiak
force-pushed
the
jk-legacy-rape-definition
branch
from
84bb793
to
03d8bca
Compare
|
Good feedback, I think I addressed both of your points |
|
😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged after #514