Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Created RuntimeService from BootstrapUtils #346

Merged
merged 5 commits into from
Jan 12, 2022
Merged

fix: Created RuntimeService from BootstrapUtils #346

merged 5 commits into from
Jan 12, 2022

Conversation

fboucquez
Copy link
Owner

Created RuntimeService from BootstrapUtils. One PR to start splitting the classes.

@lgtm-com
Copy link

lgtm-com bot commented Dec 10, 2021

This pull request introduces 3 alerts and fixes 4 when merging af44442 into 8b1e8f4 - view on LGTM.com

new alerts:

  • 2 for Unsafe shell command constructed from library input
  • 1 for Shell command built from environment values

fixed alerts:

  • 3 for Unsafe shell command constructed from library input
  • 1 for Shell command built from environment values

Jaguar0625
Jaguar0625 suggested changes Dec 13, 2021
View reviewed changes
src/service/Utils.ts Outdated Show resolved Hide resolved
test/service/RuntimeService.test.ts
const logger = LoggerFactory.getLogger(LogType.Silent);
const service = new RuntimeService(logger);
describe('RuntimeService', async () => {
it('exec when valid', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this test pass on windows?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @gimre-xymcity

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jumped over to windows and now all tests are running on windows. Afair, Travis's windows vm doesn't support docker. Keen to migrate to github actions if have the time (maybe actions works better, need to revisit)

@lgtm-com
Copy link

lgtm-com bot commented Dec 14, 2021

This pull request introduces 3 alerts and fixes 4 when merging 45ed632 into 3e9eeed - view on LGTM.com

new alerts:

  • 2 for Unsafe shell command constructed from library input
  • 1 for Shell command built from environment values

fixed alerts:

  • 3 for Unsafe shell command constructed from library input
  • 1 for Shell command built from environment values

@lgtm-com
Copy link

lgtm-com bot commented Dec 14, 2021

This pull request introduces 3 alerts and fixes 4 when merging f3bee30 into 3e9eeed - view on LGTM.com

new alerts:

  • 2 for Unsafe shell command constructed from library input
  • 1 for Shell command built from environment values

fixed alerts:

  • 3 for Unsafe shell command constructed from library input
  • 1 for Shell command built from environment values

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fboucquez fboucquez merged commit 6d02077 into dev Jan 12, 2022
@fboucquez fboucquez deleted the RuntimeService branch January 12, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaguar0625 Jaguar0625 Jaguar0625 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fboucquez @Jaguar0625