-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Created RuntimeService from BootstrapUtils #346
Conversation
7e12164
to
af44442
Compare
This pull request introduces 3 alerts and fixes 4 when merging af44442 into 8b1e8f4 - view on LGTM.com new alerts:
fixed alerts:
|
const logger = LoggerFactory.getLogger(LogType.Silent); | ||
const service = new RuntimeService(logger); | ||
describe('RuntimeService', async () => { | ||
it('exec when valid', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this test pass on windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jumped over to windows and now all tests are running on windows. Afair, Travis's windows vm doesn't support docker. Keen to migrate to github actions if have the time (maybe actions works better, need to revisit)
af44442
to
45ed632
Compare
This pull request introduces 3 alerts and fixes 4 when merging 45ed632 into 3e9eeed - view on LGTM.com new alerts:
fixed alerts:
|
45ed632
to
f3bee30
Compare
This pull request introduces 3 alerts and fixes 4 when merging f3bee30 into 3e9eeed - view on LGTM.com new alerts:
fixed alerts:
|
f3bee30
to
c610179
Compare
Excluding empty 'user' from docker compose service
SonarCloud Quality Gate failed.
|
Created RuntimeService from BootstrapUtils. One PR to start splitting the classes.