Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async send without await #6

Closed
jseynaev-cisco opened this issue May 17, 2021 · 1 comment
Closed

async send without await #6

jseynaev-cisco opened this issue May 17, 2021 · 1 comment

Comments

@jseynaev-cisco
Copy link
Contributor

jseynaev-cisco commented May 17, 2021 •
edited

  • Webex Bot version: latest pip
  • Python version: 3.8
  • Operating System: Windows and docker

Description

*****\site-packages\webex_bot\websockets\webex_websocket_client.py:100: RuntimeWarning: coroutine 'WebSocketCommonProtocol.send' was never awaited
  self.websocket.send(json.dumps(ack_message))

What I Did

Just starting the bot

It's just a warning, so I guess just adding 'await' should fix it
gconklin pushed a commit to gconklin/webex_bot that referenced this issue Mar 18, 2022
@grconkli-talos
address issue fbradyirl#6 async without await
c1bb912 
webex_bot/webex_bot/websockets/webex_websocket_client.py:102: RuntimeWarning: coroutine 'WebSocketCommonProtocol.send' was never awaited
  self.websocket.send(json.dumps(ack_message))
fbradyirl added a commit that referenced this issue Apr 7, 2022
@fbradyirl
### 0.2.20 (2022-04-07)
ae7466e 
* Fix for [#6][i6]
* Fix for [#20][i20]
* Use system SSL context when connecting websocket.
@fbradyirl
Copy link
Owner

Fixed in v0.2.20

gconklin pushed a commit to gconklin/webex_bot that referenced this issue Sep 13, 2023
@fbradyirl @gconklin
### 0.2.20 (2022-04-07)
8923699 
* Fix for [fbradyirl#6][i6]
* Fix for [fbradyirl#20][i20]
* Use system SSL context when connecting websocket.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fbradyirl @jseynaev-cisco