Fix config context to be a map of objects #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same issue is also present with LocalContextData. If this PR is approved in principle I can add that as well |
|
I'll merge this for now. We will have to see if everything works when implementing Config Contexts in terraform-provider-netbox |
fbreckle
added a commit
that referenced
this pull request
Sep 13, 2023
fbreckle
added a commit
that referenced
this pull request
Sep 13, 2023
fbreckle
added a commit
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently go-netbox fails to parse a JSON response for config context unless it fits the very simple scheme of 'a map of strings'.
This PR allows it to correctly map arbitrary JSON values for config context.
I am hitting this in terraform-provider-netbox - I'm adding a VM data source but it errors when reading the API response.