Fix LocalConfigContext to support arbitrary JSON object #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbreckle
reviewed
Feb 9, 2021
|
Hm. The original go-netbox seems to be completely unmaintained, so I cannot re-merge it. It does not look like they look into MRs either. This fork exists so I have the flexibility to change things when I need them for the terraform provider. Since the changes in this fork might be terraform-provider specific, I dont even know if they would make sense in an official go-netbox project. I will gladly merge anything (reasonable..) that helps for the terraform provider. |
jake2184
force-pushed
the
fix_local_context
branch
from
22e7e60
to
030637b
Compare
|
Well, it has 4 commits since your fork, the last of which is the same month as the last commit to this repo master. I don't need it at all, just seems fruitless to have unnecessary divergence. Removed the extra change. |
|
Can I bump this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2 - I hit the same issue but for local config context.
Is there a possibility to rebase/remerge with the upstream netbox-community/go-netbox?