Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use your own name for input context property. #1

Closed
wengxt opened this issue Apr 30, 2021 · 2 comments
Closed

Use your own name for input context property. #1

wengxt opened this issue Apr 30, 2021 · 2 comments

Comments

@wengxt
Copy link
Member

wengxt commented Apr 30, 2021

https://github.com/naokiri/fcitx5-cskk/blob/3773af3b0ef697502d98e5f4ab6afb9d1c391afb/src/cskk.cpp#L26

I know you probably take fcitx5-skk as a reference, but the input context property name need to be globally unique. This would cause problem if cskk and skk are loaded at the same time since they both use "skkState".

It is defined as a meaningful string instead of a random string just in case any external module want to reuse it, but usually the name itself doesn't matter.

@naokiri
Copy link
Member

naokiri commented Apr 30, 2021

Thanks a lot! I didn't know how it work deep inside.

@naokiri naokiri closed this as completed May 1, 2021
@naokiri
Copy link
Member

naokiri commented May 1, 2021

Fixed on latest master.

naokiri added a commit that referenced this issue Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants