Skip to content

Commit

Permalink
Merge branch 'aslakhellesoy/master'
Browse files Browse the repository at this point in the history
  • Loading branch information
bmabey committed Jan 23, 2009
2 parents 9a1d823 + cee08ca commit 4dbc634
Show file tree
Hide file tree
Showing 8 changed files with 28 additions and 14 deletions.
14 changes: 14 additions & 0 deletions History.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,24 @@
== 0.1.16.x (Git)

Bugfix release.

IMPORTANT NOTE FOR RAILS USERS.
The template used to generate your features/support/env.rb has changed. You have to apply a minor change
manually for existing Rails projects when you upgrade to this version. Change this:

require 'webrat/rspec-rails'

to this:

require 'webrat/core/matchers'

=== New features
* Finnish translation (Tero Tilus)
* Use Webrat's #contain matcher in generated "I should (not) see" step definitions (Bryan Helmkamp)

== Bugfixes
* Flush output in HTML formatter since JRuby doesnt do it automatically (Diego Carrion)
* Better handling of ARGV (#169 David Chelimsky)
* Compatibility with ruby-debug (do ARGV.dup in bin/cucumber so it can restart ruby with same args) (Aslak Hellesøy)

== 0.1.16 2009-01-19
Expand Down
6 changes: 3 additions & 3 deletions cucumber.gemspec

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion features/support/env.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require 'spec'
require 'spec/expectations'
require 'fileutils'

Before do
Expand Down
1 change: 1 addition & 0 deletions lib/cucumber/formatters/html_formatter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ def dump
</body>
</html>
HTML
@io.flush
end

private
Expand Down
9 changes: 1 addition & 8 deletions lib/cucumber/rails/rspec.rb
Original file line number Diff line number Diff line change
@@ -1,12 +1,5 @@
require 'spec/expectations'
require 'spec/rails'

# Hack to stop RSpec from dumping the summary
Spec::Runner::Options.class_eval do
def examples_should_be_run?
false
end
end
require 'spec/rails/matchers'

ActionController::Integration::Session.send(:include, Spec::Matchers)
ActionController::Integration::Session.send(:include, Spec::Rails::Matchers)
2 changes: 1 addition & 1 deletion lib/cucumber/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ class VERSION #:nodoc:
MAJOR = 0
MINOR = 1
TINY = 16
PATCH = 3 # Set to nil for official release
PATCH = 5 # Set to nil for official release

STRING = [MAJOR, MINOR, TINY, PATCH].compact.join('.')
end
Expand Down
2 changes: 1 addition & 1 deletion rails_generators/cucumber/templates/env.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@

# Comment out the next two lines if you're not using RSpec's matchers (should / should_not) in your steps.
require 'cucumber/rails/rspec'
require 'webrat/rspec-rails'
require 'webrat/core/matchers'
6 changes: 6 additions & 0 deletions spec/cucumber/formatters/html_formatter_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,12 @@ def mock_scenario_outline(stubs = {})
@io.string.should =~ /Scenario Outline/
end

it "should flush the broadcaster after dumping" do
io = mock(File, {:puts => nil})
io.should_receive(:flush)
HtmlFormatter.new(io, nil).dump
end

end
end
end

0 comments on commit 4dbc634

Please sign in to comment.