Add DirectContainer link header to ldp:hasMemberRelation checks #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whikloj
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
I can't believe I didn't notice we weren't making these Direct/Indirect containers when I was fixing it. Good work @mikejritter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3927
What does this Pull Request do?
This updates the ServerManagedTriplesIT to add the DirectContainer link header in order for the constraints to be properly checked. This ensures that the checks in
AbstractService#ensureValidDirectContainerare run and the proper 409 response is returned.How should this be tested?
mvn installInterested parties
@fcrepo/committers