Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove serialization label triple #770

Merged
merged 1 commit into from Apr 15, 2015
Merged

Remove serialization label triple #770

merged 1 commit into from Apr 15, 2015

Conversation

osmandin
Copy link
Contributor

fcrepo-1471

@@ -123,8 +123,6 @@ private void addNodeStatements(final FedoraResource resource, final UriInfo uriI

//RDF the serialization
final Resource formatRDF = createResource(REPOSITORY_NAMESPACE + key);

model.add(formatRDF, RDFS_LABEL, key);
model.add(format, dcFormat, formatRDF);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this line also pose a problem?
model.add(format, dcFormat, formatRDF);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That triple is about the "export" endpoint. Unless it's actually blocking @osmandin right now, I'm inclined to ignore it and wait 'til our later moves to genuine HTTP conneg to rip it out at that time.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question was if the triple on the next line is also showing up in RDF responses.

If indeed only the removed triple is showing a problem, let's move this PR through.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know. I'm suggesting that if it doesn't matter for @osmandin then we should probably ignore it and not spend time investigating it, because it is going to go away anyway after HTTP conneg comes through.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the absence of a response from @osmandin, I will assume the second triple is not a problem.

awoods pushed a commit that referenced this pull request Apr 15, 2015
@awoods awoods merged commit e47c670 into fcrepo:master Apr 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants