Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove serialization label triple #770

Merged
merged 1 commit into from Apr 15, 2015
Merged

Remove serialization label triple #770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions fcrepo-http-api/src/main/java/org/fcrepo/http/api/url/HttpApiResources.java
View file
Open in desktop
Expand Up @@ -123,8 +123,6 @@ private void addNodeStatements(final FedoraResource resource, final UriInfo uriI

//RDF the serialization
final Resource formatRDF = createResource(REPOSITORY_NAMESPACE + key);

model.add(formatRDF, RDFS_LABEL, key);
model.add(format, dcFormat, formatRDF);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this line also pose a problem?
model.add(format, dcFormat, formatRDF);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That triple is about the "export" endpoint. Unless it's actually blocking @osmandin right now, I'm inclined to ignore it and wait 'til our later moves to genuine HTTP conneg to rip it out at that time.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question was if the triple on the next line is also showing up in RDF responses.

If indeed only the removed triple is showing a problem, let's move this PR through.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know. I'm suggesting that if it doesn't matter for @osmandin then we should probably ignore it and not spend time investigating it, because it is going to go away anyway after HTTP conneg comes through.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the absence of a response from @osmandin, I will assume the second triple is not a problem.

}
}
Expand Down