Visitor Map tooltip shows %s for "No Visit" (matomo-org#14057)

fix matomo-org#14054 fixed the issue for me locally.
fdellwing · Jan 31, 2019 · ca6012c · ca6012c
1 parent 403c112
commit ca6012c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/plugins/UserCountryMap/Controller.php b/plugins/UserCountryMap/Controller.php
@@ -86,10 +86,11 @@ public function visitorMap($fetch = false, $segmentOverride = false)
             $this->idSite, $period, $date, $token_auth, true, $segment);
         $view->defaultMetric = array_key_exists('nb_uniq_visitors', $config['visitsSummary']) ? 'nb_uniq_visitors' : 'nb_visits';
 
+        $noVisitTranslation = $this->translator->translate('UserCountryMap_NoVisit');
         // some translations containing metric number
         $translations = array(
              'nb_visits'            => $this->translator->translate('General_NVisits'),
-             'no_visit'             => $this->translator->translate('UserCountryMap_NoVisit'),
+             'no_visit'             => $noVisitTranslation,
              'nb_actions'           => $this->translator->translate('VisitsSummary_NbActionsDescription'),
              'nb_actions_per_visit' => $this->translator->translate('VisitsSummary_NbActionsPerVisit'),
              'bounce_rate'          => $this->translator->translate('VisitsSummary_NbVisitsBounced'),
@@ -100,7 +101,8 @@ public function visitorMap($fetch = false, $segmentOverride = false)
         );
 
         foreach ($translations as &$translation) {
-            if (false === strpos($translation, '%s')) {
+            if (false === strpos($translation, '%s')
+                && $translation !== $noVisitTranslation) {
                 $translation = '%s ' . $translation;
             }
         }