Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ button docs demo #4

Merged
merged 1 commit into from
Apr 8, 2019
Merged

feat: ✨ button docs demo #4

merged 1 commit into from
Apr 8, 2019

Conversation

Quilljou
Copy link
Contributor

@Quilljou Quilljou commented Apr 6, 2019

I still have some confusion about using react/react-router-dom with Typescript. some type check of ts is failed. So I skipped the eslint verify.
There are two main parts of our docs site. /docs/xxx and /examples/xxx. the former one is a Route to contain our markdown rendered HTML document and example iPhone X display. and the next one is a Route to the contain the example content extracted from markdown. which is rendered by the handwriting webpack loader. distinguish the two kinds of loaders is by using the Rule.oneof of webpack Module.

Now the demo is available in http://localhost:10000/docs/button

@Quilljou Quilljou requested a review from huruji April 7, 2019 05:27
@huruji huruji merged commit 2d07269 into fdgio:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants