Add tests for recursive upgrade behaviors #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uirements file are upgraded. Currently only the first will be upgraded.
fdintino
added a commit
that referenced
this pull request
Jul 2, 2012
Add tests for recursive upgrade behaviors
fdintino
pushed a commit
that referenced
this pull request
Nov 20, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds tests to your fix-recursive-upgrades branch.
There are currently four new tests I've added:
test_upgrade_without_unneeded_recursive_upgrades()tests the core behavior, which is currently buggy in pip. This test would fail on pypa/develop. It passes on your branch.test_upgrade_with_needed_recursive_upgrades()tests the flip side of the core behavior -- whether recursive dependencies ARE upgraded when it's necessary. It passes on pypa/develop and also passes on your branch.test_upgrade_with_unneeded_recursive_upgrades_explicitly_requested()tests the new--upgrade-recursivefeature you implemented. It passes on your branch.test_upgrade_reqs_file_without_unneeded_recursive_upgrades()tests--upgradeagainst a requirements file. It fails on your branch: it only upgrades the first listed package in a requirements file. The same behavior would pass on pypa/develop, so this is a regression that needs to be addressed.