Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCompletion] Added "ASCompletion.DotCompletion" DataEvent #1613

Merged

Conversation

SlavaRa
Copy link

@SlavaRa SlavaRa commented May 6, 2017

This event is necessary for plugins like postfix-autocompletion and the like

@SlavaRa SlavaRa changed the title Added "ASCompletion.CompletionList.AddItems" DataEvent Added "ASCompletion.DotCompletion.AddItems" DataEvent May 6, 2017
@SlavaRa
Copy link
Author

SlavaRa commented May 6, 2017

@Neverbirth please review this PR

@SlavaRa
Copy link
Author

SlavaRa commented May 7, 2017

@Neverbirth what do you think about it?

@Neverbirth
Copy link
Contributor

I will ping you tomorrow on Slack, there is an alternative that maybe is better.

@SlavaRa
Copy link
Author

SlavaRa commented May 12, 2017

@Neverbirth ?

@SlavaRa
Copy link
Author

SlavaRa commented May 30, 2017

Bump

@SlavaRa SlavaRa closed this Aug 18, 2017
@SlavaRa SlavaRa reopened this Dec 3, 2017
@SlavaRa SlavaRa changed the title Added "ASCompletion.DotCompletion.AddItems" DataEvent [ASCompletion] Added "ASCompletion.DotCompletion.AddItems" DataEvent Dec 3, 2017
@SlavaRa SlavaRa changed the title [ASCompletion] Added "ASCompletion.DotCompletion.AddItems" DataEvent [ASCompletion] Added "ASCompletion.DotCompletion" DataEvent Dec 6, 2017
@elsassph elsassph merged commit c56db90 into fdorg:development Jan 8, 2018
@SlavaRa
Copy link
Author

SlavaRa commented Jan 8, 2018

Wow, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants