fix: Return 422 on bad push source name #3214

robhowley · 2022-09-15T01:03:01Z

Signed-off-by: Rob Howley rhowley@seatgeek.com

What this PR does / why we need it:

added a new exception for push source not found
in the feature store, raise the PushSourceNotFoundException when a push source name is provided that doesn't exist
in feature server /push endpoint, return 422 in the case of a push source not found

Which issue(s) this PR fixes:

Fixes #3210

Signed-off-by: Rob Howley <rhowley@seatgeek.com>

codecov-commenter · 2022-09-15T01:13:18Z

Codecov Report

Base: 67.31% // Head: 58.16% // Decreases project coverage by -9.15% ⚠️

Coverage data is based on head (5ef4216) compared to base (59b4853).
Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3214      +/-   ##
==========================================
- Coverage   67.31%   58.16%   -9.16%     
==========================================
  Files         179      213      +34     
  Lines       16276    17862    +1586     
==========================================
- Hits        10956    10389     -567     
- Misses       5320     7473    +2153

Flag	Coverage Δ
integrationtests	`?`
unittests	`58.16% <40.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/feature_store.py	`67.50% <0.00%> (-14.50%)`	⬇️
sdk/python/feast/feature_server.py	`31.32% <25.00%> (-39.57%)`	⬇️
...ests/integration/e2e/test_python_feature_server.py	`31.34% <50.00%> (-68.66%)`	⬇️
sdk/python/feast/errors.py	`68.08% <66.66%> (-0.03%)`	⬇️
...sts/integration/registration/test_universal_cli.py	`20.20% <0.00%> (-79.80%)`	⬇️
...ts/integration/offline_store/test_offline_write.py	`26.08% <0.00%> (-73.92%)`	⬇️
...fline_store/test_universal_historical_retrieval.py	`28.75% <0.00%> (-71.25%)`	⬇️
...dk/python/tests/integration/e2e/test_validation.py	`27.55% <0.00%> (-69.30%)`	⬇️
...s/integration/registration/test_universal_types.py	`32.25% <0.00%> (-67.75%)`	⬇️
... and 176 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

adchia

/lgtm

Signed-off-by: Rob Howley <rhowley@seatgeek.com>

robhowley · 2022-09-15T19:30:10Z

im a little confused. i signed the commits and DCO check agreed. not sure what block is referring to when it says, "Merging is blocked. The base branch requires all commits to be signed."

Signed-off-by: Rob Howley <rhowley@seatgeek.com>

adchia · 2022-09-15T20:12:47Z

Yeah that's just a red herring. Your pushed changes removed the "lgtm" tag so it couldn't merge

adchia

/lgtm

robhowley · 2022-09-15T20:50:02Z

converted to draft while i fix the integration test

Signed-off-by: Rob Howley <rhowley@seatgeek.com>

robhowley · 2022-09-28T21:00:19Z

hey @adchia, i finally got around to fixing the integration test. looks like everything passed. thanks for your patience.

adchia

/lgtm

feast-ci-bot · 2022-09-29T00:36:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, robhowley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* return 422 on bad push source name Signed-off-by: Rob Howley <rhowley@seatgeek.com> * fix: cant send empty df Signed-off-by: Rob Howley <rhowley@seatgeek.com> * return 422 on bad push source name Signed-off-by: Rob Howley <rhowley@seatgeek.com> * fix: cant send empty df Signed-off-by: Rob Howley <rhowley@seatgeek.com> * fix: json.dumps the body in the post 🤦 Signed-off-by: Rob Howley <rhowley@seatgeek.com> Signed-off-by: Rob Howley <rhowley@seatgeek.com> Co-authored-by: Rob Howley <rhowley@seatgeek.com>

## [0.25.1](v0.25.0...v0.25.1) (2022-09-30) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([f38506c](f38506c)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([a2cb995](a2cb995)) * Add stream feature view in the Web UI ([#3257](#3257)) ([47d4c93](47d4c93)) * Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([fdc8d67](fdc8d67)) * Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([8f2fb58](8f2fb58)) * Return 422 on bad push source name ([#3214](#3214)) ([8abbcd9](8abbcd9)) * Stream feature view not shown in the UI ([#3251](#3251)) ([55e28e2](55e28e2)) * Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440)) * Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([e7ed3d5](e7ed3d5))

## [0.25.1](feast-dev/feast@v0.25.0...v0.25.1) (2022-09-30) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([f38506c](feast-dev@f38506c)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([a2cb995](feast-dev@a2cb995)) * Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([47d4c93](feast-dev@47d4c93)) * Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([fdc8d67](feast-dev@fdc8d67)) * Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([8f2fb58](feast-dev@8f2fb58)) * Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([8abbcd9](feast-dev@8abbcd9)) * Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([55e28e2](feast-dev@55e28e2)) * Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440)) * Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([e7ed3d5](feast-dev@e7ed3d5))

# [0.26.0](v0.25.0...v0.26.0) (2022-10-06) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([164e666](164e666)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([6f6cbb7](6f6cbb7)) * Add stream feature view in the Web UI ([#3257](#3257)) ([1f70b3a](1f70b3a)) * Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([97b7ab9](97b7ab9)) * Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([1b312fb](1b312fb)) * Fix docker image for feature-server ([#3272](#3272)) ([eff01d1](eff01d1)) * Fix Feast UI release process to update the feast-ui package ([#3267](#3267)) ([a9d48d0](a9d48d0)) * Return 422 on bad push source name ([#3214](#3214)) ([b851e01](b851e01)) * Stream feature view meta undefined created_timestamp issue ([#3266](#3266)) ([12e1a8f](12e1a8f)) * Stream feature view not shown in the UI ([#3251](#3251)) ([e713dda](e713dda)) * Udf in stream feature view UI shows pickled data ([#3268](#3268)) ([0728117](0728117)) * Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440)) * Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([#3271](#3271)) ([b9b9c54](b9b9c54)) * Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([532d8a1](532d8a1)) ### Features * Add mysql as online store ([#3190](#3190)) ([cb8db84](cb8db84)) * Add possibility to define feature_store.yaml path with env variable ([#3231](#3231)) ([95fdb19](95fdb19)) * Add request_timeout setting for cassandra online store adapter ([#3256](#3256)) ([da20757](da20757)) * Add tag description in Field in the Feast UI ([#3258](#3258)) ([086f279](086f279)) * Adding billing_project_id in BigQueryOfflineStoreConfig ([#3253](#3253)) ([f80f05f](f80f05f)) * BigTable online store ([#3140](#3140)) ([6bc91c2](6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400) * Filter subset features in postgres [#3174](#3174) ([#3203](#3203)) ([b48d36b](b48d36b))

# [0.26.0](feast-dev/feast@v0.25.0...v0.26.0) (2022-10-06) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([164e666](feast-dev@164e666)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([6f6cbb7](feast-dev@6f6cbb7)) * Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([1f70b3a](feast-dev@1f70b3a)) * Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([97b7ab9](feast-dev@97b7ab9)) * Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([1b312fb](feast-dev@1b312fb)) * Fix docker image for feature-server ([feast-dev#3272](feast-dev#3272)) ([eff01d1](feast-dev@eff01d1)) * Fix Feast UI release process to update the feast-ui package ([feast-dev#3267](feast-dev#3267)) ([a9d48d0](feast-dev@a9d48d0)) * Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([b851e01](feast-dev@b851e01)) * Stream feature view meta undefined created_timestamp issue ([feast-dev#3266](feast-dev#3266)) ([12e1a8f](feast-dev@12e1a8f)) * Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([e713dda](feast-dev@e713dda)) * Udf in stream feature view UI shows pickled data ([feast-dev#3268](feast-dev#3268)) ([0728117](feast-dev@0728117)) * Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440)) * Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([feast-dev#3271](feast-dev#3271)) ([b9b9c54](feast-dev@b9b9c54)) * Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([532d8a1](feast-dev@532d8a1)) ### Features * Add mysql as online store ([feast-dev#3190](feast-dev#3190)) ([cb8db84](feast-dev@cb8db84)) * Add possibility to define feature_store.yaml path with env variable ([feast-dev#3231](feast-dev#3231)) ([95fdb19](feast-dev@95fdb19)) * Add request_timeout setting for cassandra online store adapter ([feast-dev#3256](feast-dev#3256)) ([da20757](feast-dev@da20757)) * Add tag description in Field in the Feast UI ([feast-dev#3258](feast-dev#3258)) ([086f279](feast-dev@086f279)) * Adding billing_project_id in BigQueryOfflineStoreConfig ([feast-dev#3253](feast-dev#3253)) ([f80f05f](feast-dev@f80f05f)) * BigTable online store ([feast-dev#3140](feast-dev#3140)) ([6bc91c2](feast-dev@6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400) * Filter subset features in postgres [feast-dev#3174](feast-dev#3174) ([feast-dev#3203](feast-dev#3203)) ([b48d36b](feast-dev@b48d36b))

return 422 on bad push source name

a0a7316

Signed-off-by: Rob Howley <rhowley@seatgeek.com>

feast-ci-bot added do-not-merge/work-in-progress size/S labels Sep 15, 2022

robhowley changed the title ~~return 422 on bad push source name~~ fix: Return 422 on bad push source name Sep 15, 2022

robhowley marked this pull request as ready for review September 15, 2022 01:14

feast-ci-bot removed the do-not-merge/work-in-progress label Sep 15, 2022

adchia approved these changes Sep 15, 2022

View reviewed changes

feast-ci-bot assigned adchia Sep 15, 2022

feast-ci-bot added lgtm approved labels Sep 15, 2022

fix: cant send empty df

c084b1b

Signed-off-by: Rob Howley <rhowley@seatgeek.com>

feast-ci-bot added size/M and removed lgtm size/S labels Sep 15, 2022

Rob Howley added 2 commits September 15, 2022 16:11

return 422 on bad push source name

570f674

Signed-off-by: Rob Howley <rhowley@seatgeek.com>

fix: cant send empty df

a4ff8c1

Signed-off-by: Rob Howley <rhowley@seatgeek.com>

adchia force-pushed the rh-push-api-error-msg branch from c084b1b to a4ff8c1 Compare September 15, 2022 20:12

adchia approved these changes Sep 15, 2022

View reviewed changes

feast-ci-bot added the lgtm label Sep 15, 2022

robhowley marked this pull request as draft September 15, 2022 20:49

feast-ci-bot added the do-not-merge/work-in-progress label Sep 15, 2022

Rob Howley added 2 commits September 27, 2022 21:29

fix: json.dumps the body in the post 🤦

2397095

Signed-off-by: Rob Howley <rhowley@seatgeek.com>

chore: merge conflicts

5ef4216

Signed-off-by: Rob Howley <rhowley@seatgeek.com>

feast-ci-bot removed the lgtm label Sep 28, 2022

robhowley marked this pull request as ready for review September 28, 2022 01:56

feast-ci-bot removed the do-not-merge/work-in-progress label Sep 28, 2022

adchia approved these changes Sep 29, 2022

View reviewed changes

feast-ci-bot added the lgtm label Sep 29, 2022

feast-ci-bot merged commit b851e01 into feast-dev:master Sep 29, 2022

robhowley deleted the rh-push-api-error-msg branch September 29, 2022 13:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Return 422 on bad push source name #3214

fix: Return 422 on bad push source name #3214

robhowley commented Sep 15, 2022 •

edited

codecov-commenter commented Sep 15, 2022 •

edited

adchia left a comment

robhowley commented Sep 15, 2022

adchia commented Sep 15, 2022

adchia left a comment

robhowley commented Sep 15, 2022 •

edited

robhowley commented Sep 28, 2022

adchia left a comment

feast-ci-bot commented Sep 29, 2022

fix: Return 422 on bad push source name #3214

fix: Return 422 on bad push source name #3214

Conversation

robhowley commented Sep 15, 2022 • edited

codecov-commenter commented Sep 15, 2022 • edited

Codecov Report

adchia left a comment

Choose a reason for hiding this comment

robhowley commented Sep 15, 2022

adchia commented Sep 15, 2022

adchia left a comment

Choose a reason for hiding this comment

robhowley commented Sep 15, 2022 • edited

robhowley commented Sep 28, 2022

adchia left a comment

Choose a reason for hiding this comment

feast-ci-bot commented Sep 29, 2022

robhowley commented Sep 15, 2022 •

edited

codecov-commenter commented Sep 15, 2022 •

edited

robhowley commented Sep 15, 2022 •

edited