fix: Add stream feature view in the Web UI #3257

hao-affirm · 2022-09-27T22:25:36Z

What this PR does / why we need it:

Show stream feature view in Feast UI

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

hao-affirm · 2022-09-27T22:26:37Z

/assign @DvirDukhan

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

adchia · 2022-09-28T13:57:10Z

ui/src/utils/custom-tabs/StreamFeatureViewCustomTabLoadingWrapper.tsx

+    feastObjectQuery.data.type !== FEAST_FV_TYPES.stream
+  ) {
+    throw new Error(
+      `This should not happen. Somehow a custom tab on a ODFV page received data that does not have the shape?`


ui/src/parsers/parseEntityRelationships.ts

ui/src/queries/useLoadRegistry.ts

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

codecov-commenter · 2022-09-28T22:35:10Z

Codecov Report

Base: 67.50% // Head: 58.19% // Decreases project coverage by -9.31% ⚠️

Coverage data is based on head (ab2d8c8) compared to base (b48d36b).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3257      +/-   ##
==========================================
- Coverage   67.50%   58.19%   -9.32%     
==========================================
  Files         179      213      +34     
  Lines       16371    17867    +1496     
==========================================
- Hits        11051    10397     -654     
- Misses       5320     7470    +2150

Flag	Coverage Δ
integrationtests	`?`
unittests	`58.19% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...sts/integration/registration/test_universal_cli.py	`20.20% <0.00%> (-79.80%)`	⬇️
...ts/integration/offline_store/test_offline_write.py	`26.08% <0.00%> (-73.92%)`	⬇️
...fline_store/test_universal_historical_retrieval.py	`28.75% <0.00%> (-71.25%)`	⬇️
...dk/python/tests/integration/e2e/test_validation.py	`27.55% <0.00%> (-69.30%)`	⬇️
...ests/integration/e2e/test_python_feature_server.py	`31.34% <0.00%> (-68.66%)`	⬇️
...s/integration/registration/test_universal_types.py	`32.25% <0.00%> (-67.75%)`	⬇️
sdk/python/feast/infra/online_stores/redis.py	`28.39% <0.00%> (-66.67%)`	⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py	`33.87% <0.00%> (-66.13%)`	⬇️
sdk/python/tests/data/data_creator.py	`34.78% <0.00%> (-65.22%)`	⬇️
...n/tests/integration/registration/test_inference.py	`35.71% <0.00%> (-64.29%)`	⬇️
... and 167 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

hao-affirm · 2022-09-30T06:26:14Z

@adchia updated. let me know if anything needs change. wanna give it a shot for the stream feature view UI

adchia

/lgtm

feast-ci-bot · 2022-09-30T14:09:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, hao-affirm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* add stream feature view to ui Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * update source Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * update example Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * add registry Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * fix lint Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * fix bug Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * add batch source Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * fix warning Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

## [0.25.1](v0.25.0...v0.25.1) (2022-09-30) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([f38506c](f38506c)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([a2cb995](a2cb995)) * Add stream feature view in the Web UI ([#3257](#3257)) ([47d4c93](47d4c93)) * Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([fdc8d67](fdc8d67)) * Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([8f2fb58](8f2fb58)) * Return 422 on bad push source name ([#3214](#3214)) ([8abbcd9](8abbcd9)) * Stream feature view not shown in the UI ([#3251](#3251)) ([55e28e2](55e28e2)) * Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440)) * Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([e7ed3d5](e7ed3d5))

## [0.25.1](feast-dev/feast@v0.25.0...v0.25.1) (2022-09-30) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([f38506c](feast-dev@f38506c)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([a2cb995](feast-dev@a2cb995)) * Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([47d4c93](feast-dev@47d4c93)) * Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([fdc8d67](feast-dev@fdc8d67)) * Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([8f2fb58](feast-dev@8f2fb58)) * Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([8abbcd9](feast-dev@8abbcd9)) * Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([55e28e2](feast-dev@55e28e2)) * Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440)) * Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([e7ed3d5](feast-dev@e7ed3d5))

# [0.26.0](v0.25.0...v0.26.0) (2022-10-06) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([164e666](164e666)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([6f6cbb7](6f6cbb7)) * Add stream feature view in the Web UI ([#3257](#3257)) ([1f70b3a](1f70b3a)) * Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([97b7ab9](97b7ab9)) * Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([1b312fb](1b312fb)) * Fix docker image for feature-server ([#3272](#3272)) ([eff01d1](eff01d1)) * Fix Feast UI release process to update the feast-ui package ([#3267](#3267)) ([a9d48d0](a9d48d0)) * Return 422 on bad push source name ([#3214](#3214)) ([b851e01](b851e01)) * Stream feature view meta undefined created_timestamp issue ([#3266](#3266)) ([12e1a8f](12e1a8f)) * Stream feature view not shown in the UI ([#3251](#3251)) ([e713dda](e713dda)) * Udf in stream feature view UI shows pickled data ([#3268](#3268)) ([0728117](0728117)) * Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440)) * Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([#3271](#3271)) ([b9b9c54](b9b9c54)) * Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([532d8a1](532d8a1)) ### Features * Add mysql as online store ([#3190](#3190)) ([cb8db84](cb8db84)) * Add possibility to define feature_store.yaml path with env variable ([#3231](#3231)) ([95fdb19](95fdb19)) * Add request_timeout setting for cassandra online store adapter ([#3256](#3256)) ([da20757](da20757)) * Add tag description in Field in the Feast UI ([#3258](#3258)) ([086f279](086f279)) * Adding billing_project_id in BigQueryOfflineStoreConfig ([#3253](#3253)) ([f80f05f](f80f05f)) * BigTable online store ([#3140](#3140)) ([6bc91c2](6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400) * Filter subset features in postgres [#3174](#3174) ([#3203](#3203)) ([b48d36b](b48d36b))

# [0.26.0](feast-dev/feast@v0.25.0...v0.26.0) (2022-10-06) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([164e666](feast-dev@164e666)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([6f6cbb7](feast-dev@6f6cbb7)) * Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([1f70b3a](feast-dev@1f70b3a)) * Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([97b7ab9](feast-dev@97b7ab9)) * Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([1b312fb](feast-dev@1b312fb)) * Fix docker image for feature-server ([feast-dev#3272](feast-dev#3272)) ([eff01d1](feast-dev@eff01d1)) * Fix Feast UI release process to update the feast-ui package ([feast-dev#3267](feast-dev#3267)) ([a9d48d0](feast-dev@a9d48d0)) * Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([b851e01](feast-dev@b851e01)) * Stream feature view meta undefined created_timestamp issue ([feast-dev#3266](feast-dev#3266)) ([12e1a8f](feast-dev@12e1a8f)) * Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([e713dda](feast-dev@e713dda)) * Udf in stream feature view UI shows pickled data ([feast-dev#3268](feast-dev#3268)) ([0728117](feast-dev@0728117)) * Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440)) * Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([feast-dev#3271](feast-dev#3271)) ([b9b9c54](feast-dev@b9b9c54)) * Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([532d8a1](feast-dev@532d8a1)) ### Features * Add mysql as online store ([feast-dev#3190](feast-dev#3190)) ([cb8db84](feast-dev@cb8db84)) * Add possibility to define feature_store.yaml path with env variable ([feast-dev#3231](feast-dev#3231)) ([95fdb19](feast-dev@95fdb19)) * Add request_timeout setting for cassandra online store adapter ([feast-dev#3256](feast-dev#3256)) ([da20757](feast-dev@da20757)) * Add tag description in Field in the Feast UI ([feast-dev#3258](feast-dev#3258)) ([086f279](feast-dev@086f279)) * Adding billing_project_id in BigQueryOfflineStoreConfig ([feast-dev#3253](feast-dev#3253)) ([f80f05f](feast-dev@f80f05f)) * BigTable online store ([feast-dev#3140](feast-dev#3140)) ([6bc91c2](feast-dev@6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400) * Filter subset features in postgres [feast-dev#3174](feast-dev#3174) ([feast-dev#3203](feast-dev#3203)) ([b48d36b](feast-dev@b48d36b))

hao-affirm added 4 commits September 27, 2022 12:03

add stream feature view to ui

f94d088

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

update source

5fb4833

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

update example

32384f3

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

add registry

a0ef748

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

hao-affirm requested a review from adchia as a code owner September 27, 2022 22:25

feast-ci-bot added the size/XL label Sep 27, 2022

feast-ci-bot assigned DvirDukhan Sep 27, 2022

fix lint

d91be15

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

adchia changed the title ~~feat: Stream feature view UI~~ fix: Add stream feature view in the Web UI Sep 28, 2022

adchia reviewed Sep 28, 2022

View reviewed changes

fix bug

fb137cc

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

hao-affirm added 2 commits September 29, 2022 00:41

add batch source

9478b10

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

fix warning

ab2d8c8

Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>

hao-affirm requested a review from adchia September 30, 2022 06:24

adchia approved these changes Sep 30, 2022

View reviewed changes

feast-ci-bot assigned adchia Sep 30, 2022

feast-ci-bot added the lgtm label Sep 30, 2022

feast-ci-bot added the approved label Sep 30, 2022

feast-ci-bot merged commit 1f70b3a into feast-dev:master Sep 30, 2022

IsraelAgundis deleted the stream-feature-view-ui branch September 1, 2023 20:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add stream feature view in the Web UI #3257

fix: Add stream feature view in the Web UI #3257

hao-affirm commented Sep 27, 2022 •

edited

hao-affirm commented Sep 27, 2022

adchia Sep 28, 2022

codecov-commenter commented Sep 28, 2022 •

edited

hao-affirm commented Sep 30, 2022

adchia left a comment

feast-ci-bot commented Sep 30, 2022

fix: Add stream feature view in the Web UI #3257

fix: Add stream feature view in the Web UI #3257

Conversation

hao-affirm commented Sep 27, 2022 • edited

hao-affirm commented Sep 27, 2022

adchia Sep 28, 2022

Choose a reason for hiding this comment

codecov-commenter commented Sep 28, 2022 • edited

Codecov Report

hao-affirm commented Sep 30, 2022

adchia left a comment

Choose a reason for hiding this comment

feast-ci-bot commented Sep 30, 2022

hao-affirm commented Sep 27, 2022 •

edited

codecov-commenter commented Sep 28, 2022 •

edited