Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build process for docker images #55

Closed
zhilingc opened this issue Jan 10, 2019 · 4 comments
Closed

Add build process for docker images #55

zhilingc opened this issue Jan 10, 2019 · 4 comments

Comments

@zhilingc
Copy link
Collaborator

To begin with, we can just push the docker images to a public gcr repository. Later we can see about migrating it to Dockerhub.

Will use google cloud build for this.

@zhilingc zhilingc mentioned this issue Jan 10, 2019
@tims
Copy link
Contributor

tims commented Jan 14, 2019

Sorry, I should have asked this earlier..

Why are we not using the maven docker plugin to build the docker images anymore? If we were using that we could push to gcr directly using mvn deploy.

@zhilingc
Copy link
Collaborator Author

Sorry, I should have asked this earlier..

Why are we not using the maven docker plugin to build the docker images anymore? If we were using that we could push to gcr directly using mvn deploy.

We needed to build ingestion first then bake both ingestion and core jars (which are in separate directories) into the core docker image. There wasn't a way to do it with the maven docker plugin.

@tims
Copy link
Contributor

tims commented Jan 15, 2019

I'm looking into a way around this.. if we could use the mvn native way, then we can utilize auto tagging of commits and auto incrementing of snapshot and release versions.

@tims
Copy link
Contributor

tims commented Jan 18, 2019

closing this as it's fine for now.

@tims tims closed this as completed Jan 18, 2019
dmartinol added a commit to dmartinol/feast that referenced this issue Jul 29, 2024
…ak-integration-test

Updating the existing remote online integration test with auth permissions configurations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants