Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise import error when repo configs module cannot be imported #2065

Merged

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: Previously when the full repo configs module could not be imported, the error was suppressed and the integration tests continued with the default repo configs. This makes it difficult for users who are trying to extend the test suite to realize the issue is an import error.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Copy link
Collaborator Author

/kind housekeeping

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817, MattDelac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MattDelac,achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #2065 (ebcbdab) into master (640fd68) will decrease coverage by 0.76%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2065      +/-   ##
==========================================
- Coverage   83.59%   82.82%   -0.77%     
==========================================
  Files         100      100              
  Lines        8077     8136      +59     
==========================================
- Hits         6752     6739      -13     
- Misses       1325     1397      +72     
Flag Coverage Δ
integrationtests 73.74% <33.33%> (-0.28%) ⬇️
unittests 58.21% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 94.56% <33.33%> (+0.05%) ⬆️
sdk/python/feast/infra/offline_stores/bigquery.py 64.34% <0.00%> (-17.05%) ⬇️
sdk/python/feast/infra/aws.py 72.59% <0.00%> (-11.06%) ⬇️
.../integration/online_store/test_universal_online.py 98.13% <0.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 640fd68...ebcbdab. Read the comment docs.

@feast-ci-bot feast-ci-bot merged commit 680a489 into feast-dev:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants