Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise import error when repo configs module cannot be imported #2065

Merged
merged 1 commit into from Nov 18, 2021
Merged

Raise import error when repo configs module cannot be imported #2065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions sdk/python/tests/integration/feature_repos/repo_configuration.py
View file
Open in desktop
Expand Up @@ -15,6 +15,7 @@
from feast import FeatureStore, FeatureView, RepoConfig, driver_test_data
from feast.constants import FULL_REPO_CONFIGS_MODULE_ENV_NAME
from feast.data_source import DataSource
from feast.errors import FeastModuleImportError
from tests.integration.feature_repos.integration_test_repo_config import (
IntegrationTestRepoConfig,
)
Expand Down Expand Up @@ -86,8 +87,10 @@
try:
module = importlib.import_module(full_repo_configs_module)
FULL_REPO_CONFIGS = getattr(module, "FULL_REPO_CONFIGS")
except Exception:
FULL_REPO_CONFIGS = DEFAULT_FULL_REPO_CONFIGS
except Exception as e:
raise FeastModuleImportError(
"FULL_REPO_CONFIGS", full_repo_configs_module
) from e
else:
FULL_REPO_CONFIGS = DEFAULT_FULL_REPO_CONFIGS

Expand Down