Feat: Pydantic Model Compatibility #3667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtial work for FeatureService pydantic model, and add unit tests for pydantic models.
…, fix FeatureView to not desroy some of its arguments
… on DataSource and Entity, so use those converters in the FeatureView converter. Also, fix a small SparkSource error which imports FeatureView into the SparkSource DataSource definition, breaking the hierarchy of FeatureService to FeatureView to DataSource and Entity, causing circular dependencies
…antic model, and do some linting
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: expediamatt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Wrong branch, my apologies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[All tests and lint checks are passing.]
What this PR does / why we need it:
This PR introduces Pydantic model conversions for Entity, DataSource, and FeatureView, so that they may be transmitted over the wire using FastAPI. This allows a Feast project to be broken up into a local SDK and a remote registry service.
Only RequestSource and SparkSource are supported for now. We plan to add support for FeatureService models in the near future.