Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Pydantic Model Compatibility #3667

Closed
wants to merge 22 commits into from
Closed

Feat: Pydantic Model Compatibility #3667

wants to merge 22 commits into from

Commits on Jun 23, 2023

  1. change package name, create branch

    William Parsley committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    98aa248 View commit details
    Browse the repository at this point in the history

  2. remove publish and release actions

    William Parsley committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    8b5b2dd View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Subclass Entity to Pydantic BaseModel so it can be sent and received … 

    …by FastAPI
    @expediamatt
    expediamatt committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    b18eee1 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Add Pydantic Model conversion to Entity instead of subclassing it

    @expediamatt
    expediamatt committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    53a6fe7 View commit details
    Browse the repository at this point in the history

  2. Fix accidental python requirement change

    @expediamatt
    expediamatt committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    9a8259d View commit details
    Browse the repository at this point in the history

  3. Add Pydantic Model conversion to two DataSources, RequestSource and S… 

    …parkSource
    @expediamatt
    expediamatt committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    de11bcf View commit details
    Browse the repository at this point in the history

  4. Add Pydantic Model conversion to FeatureView

    @expediamatt
    expediamatt committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    051631f View commit details
    Browse the repository at this point in the history

  5. Fix some optional strings for Pydantic models

    @expediamatt
    expediamatt committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    caf9c59 View commit details
    Browse the repository at this point in the history

  6. Fix small errors in DataSource and FeatureView pydantic models, do pa… 

    …rtial work for FeatureService pydantic model, and add unit tests for pydantic models.
    @expediamatt
    expediamatt committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    623fab7 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2023

  1. Add FeatureView Pydantic Model test, fix FeatureView model conversion… 

    …, fix FeatureView to not desroy some of its arguments
    @expediamatt
    expediamatt committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    83fdbc9 View commit details
    Browse the repository at this point in the history

  2. Fix Entity json encoding in FeatureView pydantic model

    @expediamatt
    expediamatt committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    eae1e94 View commit details
    Browse the repository at this point in the history

  3. Small bug fix to make Entity list optional in FeatureViews pydantic m… 

    …odel
    @expediamatt
    expediamatt committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    d62e2d7 View commit details
    Browse the repository at this point in the history

  4. Fix Pydantic model conversions with dependencies. FeatureView depends… 

    … on DataSource and Entity, so use those converters in the FeatureView converter. Also, fix a small SparkSource error which imports FeatureView into the SparkSource DataSource definition, breaking the hierarchy of FeatureService to FeatureView to DataSource and Entity, causing circular dependencies
    @expediamatt
    expediamatt committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    66fb923 View commit details
    Browse the repository at this point in the history

  5. WIP. Try adding more types to json encoder to get type checking to work.

    @expediamatt
    expediamatt committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    f0c46b6 View commit details
    Browse the repository at this point in the history

  6. WIP. Fixing json encoding of types

    @expediamatt
    expediamatt committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    db65d80 View commit details
    Browse the repository at this point in the history

  7. Make FeastTypes Pydantic compatible

    @expediamatt
    expediamatt committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    db3197e View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Fix DatatSourceModel to SparkSource pydantic conversion and add tests

    @expediamatt
    expediamatt committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    ba7bb27 View commit details
    Browse the repository at this point in the history

  2. Allow dtypes to be defined by strings, add more tests

    @expediamatt
    expediamatt committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    4768532 View commit details
    Browse the repository at this point in the history

  3. Adjust schema conversion in RequestSource datasource_from_pydantic_model

    @expediamatt
    expediamatt committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    65f8698 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary properties from FeatureView pydantic model

    @expediamatt
    expediamatt committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    34109e5 View commit details
    Browse the repository at this point in the history

  5. Remove parameters that weren't removed last time from FeatureView pyd… 

    …antic model, and do some linting
    @expediamatt
    expediamatt committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    47e98b9 View commit details
    Browse the repository at this point in the history

  6. Finish linting

    @expediamatt
    expediamatt committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    a6f0253 View commit details
    Browse the repository at this point in the history