fix: Refactor auth_client_manager_factory.py in function get_auth_client_m… #4505
+144
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anager Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
tmihalac
force-pushed
the
small-refactor-intra-comm
branch
from
0ac4a9e
to
619f8a8
Compare
…anager -Added test Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
sdk/python/tests/unit/permissions/auth/client/test_authentication_client_manager_factory.py
Outdated
Show resolved
Hide resolved
…anager -updated test following review Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
…anager -fixed linter Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…anager
What this PR does / why we need it:
Refactor auth_client_manager_factory.py` in function get_auth_client_manager
Which issue(s) this PR fixes:
Fixes #4504