-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Clear all the futures when sync is called. #501
Conversation
/ok-to-test |
ingestion/src/main/java/feast/store/serving/redis/RedisStandaloneIngestionClient.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments.
ingestion/src/main/java/feast/store/serving/redis/RedisStandaloneIngestionClient.java
Show resolved
Hide resolved
/approved |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lavkesh, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Replacing Jedis With Lettuce in ingestion and serving * Removing extra lines * Abstacting redis connection based on store * Check the connection before connecting as lettuce does the retry automatically * Running spotless * Throw Exception if the job store config is null * Handle No enum constant RuntimeException * Future should be cleared everytime sync is called
* Replacing Jedis With Lettuce in ingestion and serving * Removing extra lines * Abstacting redis connection based on store * Check the connection before connecting as lettuce does the retry automatically * Running spotless * Throw Exception if the job store config is null * Handle No enum constant RuntimeException * Future should be cleared everytime sync is called
Futures may contain exception when retry happens. Futures.waitAll() returns when it encounters an exception. This will cause execute() call to never succeed.
So sync() call should clear future List so that retry can proceed.