[Bug] Clear all the futures when sync is called. #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavkesh
requested review from
davidheryanto,
khorshuheng and
woop
as code owners
|
/ok-to-test |
woop
reviewed
Feb 27, 2020
ingestion/src/main/java/feast/store/serving/redis/RedisStandaloneIngestionClient.java
Show resolved
Hide resolved
woop
reviewed
Feb 27, 2020
ingestion/src/main/java/feast/store/serving/redis/RedisStandaloneIngestionClient.java
Show resolved
Hide resolved
|
/approved |
woop
approved these changes
Feb 27, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lavkesh, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
khorshuheng
pushed a commit
to khorshuheng/feast
that referenced
this pull request
Mar 17, 2020
* Replacing Jedis With Lettuce in ingestion and serving * Removing extra lines * Abstacting redis connection based on store * Check the connection before connecting as lettuce does the retry automatically * Running spotless * Throw Exception if the job store config is null * Handle No enum constant RuntimeException * Future should be cleared everytime sync is called
khorshuheng
pushed a commit
that referenced
this pull request
Mar 17, 2020
* Replacing Jedis With Lettuce in ingestion and serving * Removing extra lines * Abstacting redis connection based on store * Check the connection before connecting as lettuce does the retry automatically * Running spotless * Throw Exception if the job store config is null * Handle No enum constant RuntimeException * Future should be cleared everytime sync is called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Futures may contain exception when retry happens. Futures.waitAll() returns when it encounters an exception. This will cause execute() call to never succeed.
So sync() call should clear future List so that retry can proceed.