Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport delay in Redis acknowledgement of spec #915

Merged
merged 1 commit into from
Aug 1, 2020

Conversation

woop
Copy link
Member

@woop woop commented Aug 1, 2020

What this PR does / why we need it:
Adds a delay to Redis spec send acknowledgement in order to prevent a race condition with the send event being commited.

Does this PR introduce a user-facing change?:

Occasionally feature sets might enter a pending state due to a race condition with spec acknowledgement. This race has been resolved.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

@woop: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end-batch-dataflow 79aabbf link /test test-end-to-end-batch-dataflow

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@woop woop merged commit 348cdfd into feast-dev:v0.6-branch Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants