🧹 Improved email validation error message (#284)

* fix: display different error messages when feedback email is empty or invalid * revert wrongly changes * code clean * clean * use built in email validator * clean
featbit · Mar 17, 2023 · ca827aa · ca827aa
1 parent f60dd6c
commit ca827aa
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/modules/front-end/src/app/core/components/header/header.component.html b/modules/front-end/src/app/core/components/header/header.component.html
@@ -92,7 +92,7 @@
     <form nz-form [formGroup]="feedbackForm" nzLayout="vertical">
       <nz-form-item>
         <nz-form-label nzRequired i18n="@@common.email">Email</nz-form-label>
-        <nz-form-control nzHasFeedback i18n-nzErrorTip="@@common.email-cannot-be-empty" nzErrorTip="Email cannot be empty">
+        <nz-form-control nzHasFeedback i18n-nzErrorTip="@@common.email-invalid" nzErrorTip="Invalid Email">
           <input nz-input formControlName="email" />
         </nz-form-control>
       </nz-form-item>

diff --git a/modules/front-end/src/locale/messages.xlf b/modules/front-end/src/locale/messages.xlf
@@ -1845,8 +1845,8 @@
           <context context-type="linenumber">30</context>
         </context-group>
       </trans-unit>
-      <trans-unit id="common.email-cannot-be-empty" datatype="html">
-        <source>Email cannot be empty</source>
+      <trans-unit id="common.email-invalid" datatype="html">
+        <source>Invalid Email</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/core/components/header/header.component.html</context>
           <context context-type="linenumber">95,96</context>

diff --git a/modules/front-end/src/locale/messages.zh.xlf b/modules/front-end/src/locale/messages.zh.xlf
@@ -1973,13 +1973,13 @@
         </context-group>
         <target>邮箱</target>
       </trans-unit>
-      <trans-unit id="common.email-cannot-be-empty" datatype="html">
-        <source>Email cannot be empty</source>
+      <trans-unit id="common.email-invalid" datatype="html">
+        <source>Invalid Email</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/core/components/header/header.component.html</context>
           <context context-type="linenumber">95,96</context>
         </context-group>
-        <target>邮箱不能为空</target>
+        <target>邮箱地址无效</target>
       </trans-unit>
       <trans-unit id="common.message" datatype="html">
         <source>Message</source>