Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Improved email validation error message #284

Merged
merged 6 commits into from
Mar 17, 2023
Merged

🧹 Improved email validation error message #284

merged 6 commits into from
Mar 17, 2023

Conversation

cosmos-explorer
Copy link
Contributor

@cosmos-explorer cosmos-explorer commented Mar 17, 2023 •
edited

image

image

@cosmos-explorer cosmos-explorer changed the title ✨ Display different error messages when feedback email is empty or invalid ✨ Display Invalid Email error message when feedback email is empty or invalid Mar 17, 2023
@deleteLater deleteLater changed the title ✨ Display Invalid Email error message when feedback email is empty or invalid 🧹 Improved email validation error message Mar 17, 2023
deleteLater
deleteLater reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@deleteLater deleteLater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cosmos-explorer cosmos-explorer merged commit ca827aa into main Mar 17, 2023
@cosmos-explorer cosmos-explorer deleted the fix/feedback-email-validator branch March 17, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deleteLater deleteLater deleteLater approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cosmos-explorer @deleteLater