✨ Add description field to new feature form #259
Conversation
| <textarea nz-input formControlName="description" placeholder="Description"> | ||
| </textarea> | ||
| </nz-form-control> | ||
| </nz-form-item> |
There was a problem hiding this comment.
Great work, thank you @sagar110599 , may I ask you to do one more thing? We need to support i18n for all labels, we are using the official @angular/localize package. Can you modify this block of code like this?
<nz-form-item>
<nz-form-label i18n="@@common.description">Description</nz-form-label>
<nz-form-control nzHasFeedback nzErrorTip="Cannot exceed 512 characters" i18n-nzErrorTip="@@ff.description.cannot-exceed-512-characters">
<textarea nz-input formControlName="description" i18n-placeholder="@@common.description" placeholder="Description">
</textarea>
</nz-form-control>
</nz-form-item>After that, please run: npm run i18n, this would generate the i18n resources, don't worry about the translation, we can do it afterwards.
There was a problem hiding this comment.
Hi @cosmos-explorer , After updating the HTML as suggested and running the command npm run i18n following files got updated which are seen in screenshot. Do i need to commit those as well??
There was a problem hiding this comment.
Hi @sagar110599 , Yes, those files are the translation files, they need to be committed
There was a problem hiding this comment.
Updated commit as per suggestions.
cosmos-explorer
changed the title
|
@all-contributors |
|
I've put up a pull request to add @sagar110599! 🎉 |
No description provided.