Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: api & evaluation-server shutdown errors #283

Merged
merged 2 commits into from
Mar 17, 2023
Merged

🐛 fix: api & evaluation-server shutdown errors #283

merged 2 commits into from
Mar 17, 2023

Conversation

deleteLater
Copy link
Contributor

@deleteLater deleteLater commented Mar 17, 2023 •
edited
Loading

This PR aims to resolve errors observed when shutting down the api and evaluation server.

To reproduce

  1. dotnet run
  2. press ctrl+c to shutdown process

Before
image

After
image

refs:

@deleteLater deleteLater self-assigned this Mar 17, 2023
@deleteLater deleteLater added the enhancement New feature or request label Mar 17, 2023
@deleteLater deleteLater marked this pull request as ready for review March 17, 2023 05:02
@cosmos-explorer cosmos-explorer deleted the fix/error-when-shutdown branch March 17, 2023 06:21
@deleteLater deleteLater restored the fix/error-when-shutdown branch March 17, 2023 06:35
@deleteLater deleteLater reopened this Mar 17, 2023
@cosmos-explorer cosmos-explorer merged commit f60dd6c into main Mar 17, 2023
@cosmos-explorer cosmos-explorer deleted the fix/error-when-shutdown branch March 17, 2023 07:42
@cosmos-explorer
Copy link
Contributor

@all-contributors
please add @deleteLater for Code

@allcontributors allcontributors bot mentioned this pull request Mar 21, 2023
Merged
@allcontributors
Copy link
Contributor

@cosmos-explorer

I've put up a pull request to add @deleteLater! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmos-explorer cosmos-explorer cosmos-explorer approved these changes

Assignees

@deleteLater deleteLater

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deleteLater @cosmos-explorer