🧹 refactor: replace lodash with lodash-es
#378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/front-end/angular.json
Outdated
There was a problem hiding this comment.
Hello @defqd , Thank you for your PR.
Have you check the recommended way in this answer? https://stackoverflow.com/a/62589268
With this, we don't need to add allowedCommonJsDependencies
There was a problem hiding this comment.
Hello @cosmos-explorer, I checked. The warning has disappeared.
deleteLater
changed the title
lodash with lodash-es
modules/front-end/package.json
Outdated
| @@ -21,6 +21,7 @@ | |||
| "@angular/platform-browser-dynamic": "^14.0.0", | |||
| "@angular/router": "^14.0.0", | |||
| "@antv/g2": "^4.2.7", | |||
| "lodash-es": "^4.17.21", | |||
| "lodash.differenceby": "^4.8.0", | |||
There was a problem hiding this comment.
You can remove
- lodash.differenceby
- lodash.get
- lodash.intersectionby
- lodash.keyby
Then rerun npm i
cosmos-explorer
approved these changes
May 24, 2023
|
LGTM! Thank you very much |
|
@all-contributors |
|
I've put up a pull request to add @defqd! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported specific methods individually instead of import the whole 'lodash' library