Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🖍 fix: truncate long variation value with ellipsis #434

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

deleteLater
Copy link
Contributor

Before

image

After

image

@deleteLater deleteLater self-assigned this Jul 6, 2023
@deleteLater deleteLater added bug Something isn't working ui labels Jul 6, 2023
@deleteLater deleteLater marked this pull request as ready for review July 6, 2023 10:05
@deleteLater deleteLater changed the title 🖍 fix: ellipsis long variation value 🖍 fix: ellipse long variation value Jul 6, 2023
@deleteLater deleteLater changed the title 🖍 fix: ellipse long variation value 🖍 fix: truncate long variation value with ellipsis Jul 6, 2023
Copy link
Contributor

@cosmos-explorer cosmos-explorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cosmos-explorer cosmos-explorer merged commit ab1f7ae into main Jul 7, 2023
1 check passed
@cosmos-explorer cosmos-explorer deleted the fix/variation-value-style branch July 7, 2023 09:41
cosmos-explorer pushed a commit that referenced this pull request Jul 10, 2023
* feat: add icon on header that redirect on the docs

* fix: add target=_blank to the link so the doc page would be open in a new tab

* 🖍 fix: truncate long variation value with ellipsis (#434)

* fix

* update i18n

* feat: run the test i18n

---------

Co-authored-by: deleteLater <mikcczhang@gmail.com>
mucoban pushed a commit to mucoban/featbit that referenced this pull request Jul 12, 2023
mucoban pushed a commit to mucoban/featbit that referenced this pull request Jul 12, 2023
* feat: add icon on header that redirect on the docs

* fix: add target=_blank to the link so the doc page would be open in a new tab

* 🖍 fix: truncate long variation value with ellipsis (featbit#434)

* fix

* update i18n

* feat: run the test i18n

---------

Co-authored-by: deleteLater <mikcczhang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants