-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ UI feat: add icon on header that redirect on the docs #436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
@all-contributors |
I could not determine your intention. Basic usage: @all-contributors please add @Someone for code, doc and infra For other usages see the documentation |
@all-contributors please add @LeeBingler for code |
I've put up a pull request to add @LeeBingler! 🎉 |
* feat: add icon on header that redirect on the docs * fix: add target=_blank to the link so the doc page would be open in a new tab * 🖍 fix: truncate long variation value with ellipsis (featbit#434) * fix * update i18n * feat: run the test i18n --------- Co-authored-by: deleteLater <mikcczhang@gmail.com>
Add a target=_blank to the link, merging the branch with the main and run the npm i18n command before commit
Issue #395