Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ UI feat: add icon on header that redirect on the docs #436

Merged
merged 5 commits into from
Jul 10, 2023
Merged

✨ UI feat: add icon on header that redirect on the docs #436

merged 5 commits into from
Jul 10, 2023

Conversation

LeeBingler
Copy link
Contributor

Add a target=_blank to the link, merging the branch with the main and run the npm i18n command before commit
Issue #395

@cosmos-explorer cosmos-explorer changed the title 🐛 fix: add target="_blank" to the link ✨ UI feat: add icon on header that redirect on the docs Jul 10, 2023
Copy link
Contributor

@cosmos-explorer cosmos-explorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@cosmos-explorer cosmos-explorer merged commit 49fdc65 into featbit:main Jul 10, 2023
1 check passed
@cosmos-explorer
Copy link
Contributor

@all-contributors
Please @LeeBingler for code

@allcontributors
Copy link
Contributor

@cosmos-explorer

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@cosmos-explorer
Copy link
Contributor

@all-contributors please add @LeeBingler for code

@allcontributors
Copy link
Contributor

@cosmos-explorer

I've put up a pull request to add @LeeBingler! 🎉

mucoban pushed a commit to mucoban/featbit that referenced this pull request Jul 12, 2023
* feat: add icon on header that redirect on the docs

* fix: add target=_blank to the link so the doc page would be open in a new tab

* 🖍 fix: truncate long variation value with ellipsis (featbit#434)

* fix

* update i18n

* feat: run the test i18n

---------

Co-authored-by: deleteLater <mikcczhang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants