Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Request: Currency #182

Open
dags170291 opened this issue Sep 10, 2017 · 44 comments · May be fixed by #670
Open

Icon Request: Currency #182

dags170291 opened this issue Sep 10, 2017 · 44 comments · May be fixed by #670

Comments

@dags170291
Copy link

I'm Currently working on a branding project I love just how these icons look with the resume in my project. it would be awesome if I can get a set of currency icons that is uniform with the rest of my project thanks.

@colebemis
Copy link
Member

Could you be more specific about which currency icons you'd like? USD? Euro? Screenshots would be super helpful 😊

@dags170291
Copy link
Author

My apologies I meant currency symbols e.g.
artboard

@kumarharsh
Copy link

+1 add INR too if possible (₹)
image

@cassiewallace
Copy link

Would love currency symbols!

@fizzvr
Copy link

fizzvr commented Oct 11, 2017

Sup this.

@pcorey
Copy link

pcorey commented Nov 29, 2017

A dollar icon would be super useful. It's general enough to accommodate a good number of use cases.
👍

colebemis added a commit that referenced this issue Dec 15, 2017
colebemis added a commit that referenced this issue Dec 15, 2017
@AlfredReisner
Copy link

In addition to the dollar-sign it would be very nice to add EUR as well. Thanks a lot!

@Jolievin
Copy link

Jolievin commented Jun 8, 2018

I really need a pound sterling GBP £ icon British currency ;)

@LittleGyaani
Copy link

Missing the INR icon (₹), waiting for it to be added in next release quickly.

@zolo-n
Copy link

zolo-n commented Mar 28, 2019

I still miss a Euro sign €
and I think some currency neutral sign, such a bill (banknote) would be highly appreciated too

@locness3
Copy link

#171

@jletey
Copy link

jletey commented Jul 1, 2019

@locness3 @colebemis @dags170291 @kumarharsh @LittleGyaani @Jolievin How does this look? I have designed INR and GBP icons!

Do you guys have any other currency icons that you want me to design?

EDIT: Have also added the Japanese Yen symbol!
EDIT-2: Have also added the Russian Ruble symbol!

@jletey
Copy link

jletey commented Jul 1, 2019

@locness3 @areisner @zolo-n I have added the Euro icon, the Swiss Franc icon, and the Bitcoin icon!

Screen Shot 2019-07-01 at 7 40 27 PM

Please do let me know if you guys would like any other icons designed!

@jletey
Copy link

jletey commented Jul 8, 2019

@locness3 @ahtohbi4 What does everyone think of the banknote? Figma

Screen Shot 2019-07-08 at 8 07 12 AM

@jletey
Copy link

jletey commented Jul 8, 2019

I have updated the EUR icon! Figma

Screen Shot 2019-07-08 at 8 13 51 AM

Old

Screen Shot 2019-07-08 at 8 15 17 AM

New

@locness3
Copy link

locness3 commented Jul 8, 2019

Both look perfect!

@jletey
Copy link

jletey commented Jul 8, 2019

Great @locness3 ... i'm going to add all of these icons and open a PR!

jletey added a commit to jletey/feather that referenced this issue Jul 8, 2019
@jletey jletey linked a pull request Jul 8, 2019 that will close this issue
@jletey
Copy link

jletey commented Jul 21, 2019

Hey everyone, I redid the BTC (bitcoin) icon ... what does everyone think?

cc @locness3 @ahtohbi4

Shot 2019-07-21 at 09 05 52

New icon

Shot 2019-07-21 at 09 07 06

Side-by-side

@locness3
Copy link

Great!

@LoopsGod
Copy link

LoopsGod commented Feb 9, 2020

Any updates on this?

@locness3
Copy link

locness3 commented Feb 16, 2020

@J0XX0 We need to get @colebemis to merge #670
Please, @colebemis...

@zakariamehbi
Copy link

No update?

@locness3
Copy link

locness3 commented Apr 4, 2020

No.

@scodeler
Copy link

scodeler commented Jun 5, 2020

Hello, everyone
I did some new icons (pound, rupee, yen, euro - didn't see somebody had already done it)
@kumarharsh and @LittleGyaani, could you tell me if the rupee glyph is correct? I am not familiar with the symbol

icons

@johnletey
Copy link

didn't see somebody had already done it

@scodeler Take a look at #670. I (well on my old account that I've now lost access to) designed these. But I am a fan of your icons :)

@kumarharsh
Copy link

Yup, ₹ looks cool!

@scodeler
Copy link

scodeler commented Jun 5, 2020

@jletey, nice work! I'll send the missing icons then

@LoopsGod
Copy link

LoopsGod commented Jun 6, 2020

@scodeler unfortunately you have about a 0% that your addition will get merged. This repository sucks does not suck it is just unmaintained. I highly suggest choosing another icon framework or source your own if you need to use a diverse category of icons.

@locness3
Copy link

locness3 commented Jun 7, 2020

I understand why you feel this way, @J0XX0, but it being unmaintained doesn't make it suck; rather, @colebemis doesn't have time to review submissions as he would like to, to keep it good quality. Please do not hate.

@locness3
Copy link

locness3 commented Jun 7, 2020

Would some folks volunteer to maintain a fork with the icons submitted?

@LoopsGod
Copy link

LoopsGod commented Jun 7, 2020

I understand why you feel this way, @J0XX0, but it being unmaintained doesn't make it suck; rather, @colebemis doesn't have time to review submissions as he would like to, to keep it good quality. Please do not hate.

Maybe not suck, but does make it useless. 300 icons vs 800+ icons on fontawesome & endless icons on flaticon.com

Much better to source your own SVGs considering much are not included anyways, such as currency; a crucial and very popular icon. Why does it take so much time to merge a simple PR?

Just my opinion. Not hate, just criticism.

P.S.: This PR / issue is open for about 3 years... Kind of sad imo, an icon framework needs to iterate quick. Fontawesome is pushing out a new icon set every year...

P.P.S.: Don't get me wrong, if the moderation issue gets fixed Feather Icons could defo be No.1 icon framework. It just frustates me that I've chosen an icon pack, just need to use a currency icon and then it's not available & a perfect well-created PR is open since 2017. I hope #893 will help out the repo! I'm available for help as well.

@johnletey
Copy link

Would some folks volunteer to maintain a fork with the icons submitted?

I have, and still would love too!

@locness3
Copy link

locness3 commented Jun 7, 2020

It just frustates me that I've chosen an icon pack, just need to use a currency icon and then it's not available

You know, you can use the SVGs from PRs ;)

an icon framework needs to iterate quick. Fontawesome is pushing out a new icon set every year...

Fontawesome have more people, and they also sell stuff, where Feather is free and maintained by 1 person.

I have, and still would love too! (@jletey)

wdym "have"?

@johnletey
Copy link

wdym "have"? (@locness3)

#893 (comment)

@locness3
Copy link

locness3 commented Jun 8, 2020

I'm talking about maintaining a seperate fork :)

@johnletey
Copy link

johnletey commented Jun 8, 2020

@locness3 I have gone ahead and created a fork and invited you and @ahtohbi4 to maintain it :)

Might be best to create an org? I've also deployed the existing site to feather.now.sh, so we have that URL as well.

Not entirely quite sure the best way to move forward with the PRs, as the PRs don't transfer :/

@locness3
Copy link

locness3 commented Jun 9, 2020

I think we should ask ppl to redo their PRs for the fork

@locness3
Copy link

locness3 commented Jun 9, 2020

Also, where does the site deploy from?

@johnletey
Copy link

johnletey commented Jun 9, 2020

I think we should ask ppl to redo their PRs for the fork

I agree 👍

Also, where does the site deploy from?

Right now it's being deployed from Vercel - the code is all local, I deployed quickly so that no-one would steal the feather.now.sh domain 😅

I will be pushing some a "v2" of the site to my repo soon. A redesign, but most importantly, loading the icons from the icons dir so we have live previews of icon PRs :)

@locness3
Copy link

locness3 commented Jun 9, 2020

Yeah, please put the site in the repo

@johnletey
Copy link

@locness3 You can follow along here: https://github.com/jletey/feather/pull/1 😄

@inkedbyjay
Copy link

Hello, everyone
I did some new icons (pound, rupee, yen, euro - didn't see somebody had already done it)
@kumarharsh and @LittleGyaani, could you tell me if the rupee glyph is correct? I am not familiar with the symbol

icons

This is correct for INR - Rupee

@tolutronics
Copy link

please add Naira sign too

@Afam6
Copy link

Afam6 commented Nov 5, 2021

Naira sign is pretty basic

<svg xmlns="http://www.w3.org/2000/svg" width="20" height="20" 
viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" 
stroke-linecap="round" stroke-linejoin="round" class="feather feather-hash">
<line x1="0" y1="9" x2="24" y2="9"></line>
<line x1="0" y1="15" x2="24" y2="15"></line>
<line x1="6" y1="0" x2="6" y2="24"></line>
<line x1="18" y1="0" x2="18" y2="24"></line>

<line x1="6" y1="0" x2="18" y2="24"></line>
</svg>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.