Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Request: Code with Forward Slash #399

Open
polys opened this issue Apr 19, 2018 · 11 comments · May be fixed by #671
Open

Icon Request: Code with Forward Slash #399

polys opened this issue Apr 19, 2018 · 11 comments · May be fixed by #671

Comments

@polys
Copy link

polys commented Apr 19, 2018

Can I please request the following icon:

Icon Name: code-slash

Use Case:

  • An icon similar to the existing code but more aligned with other icon sets
  • Could be used as an icon for developer resources, integration options, code listings, etc.

Similar to https://fontawesome.com/icons/code or this:
image

Many thanks in advance!

@jletey
Copy link

jletey commented Jun 23, 2019

@colebemis @locness3 @polys How does this look?

@locness3
Copy link

@colebemis @locness3 @polys How does this look?

#171

@jletey
Copy link

jletey commented Jul 8, 2019

@locness3 @ahtohbi4 @polys How does it look now? Figma

Screen Shot 2019-07-08 at 7 48 32 AM

Screen Shot 2019-07-08 at 7 53 24 AM

Note that I resized the two code symbols on the left and right of the forward slash

@locness3
Copy link

locness3 commented Jul 8, 2019

The slash looks a bit too close on small size. maybe spacing it more with the < >

@jletey
Copy link

jletey commented Jul 8, 2019

@locness3 Shrunk the < > a little more ... how does it look now?

Screen Shot 2019-07-08 at 9 48 42 AM

@ahtohbi4
Copy link
Contributor

ahtohbi4 commented Jul 8, 2019

@johnletey could you show the last one in a set?

@locness3
Copy link

locness3 commented Jul 8, 2019

That's great! Could you do a side-by-side as @ahtohbi4 said ?

@jletey
Copy link

jletey commented Jul 9, 2019

@ahtohbi4 @locness3

Screen Shot 2019-07-09 at 7 38 40 AM

@locness3
Copy link

locness3 commented Jul 9, 2019

That looks perfect!

@polys
Copy link
Author

polys commented Jul 9, 2019

Thanks, that's really good!

@jletey
Copy link

jletey commented Jul 9, 2019

Awesome ... I'm going to submit a PR now!

jletey added a commit to jletey/feather that referenced this issue Jul 9, 2019
@jletey jletey linked a pull request Jul 9, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants