Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add code-2 icon #671

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jletey
Copy link

@jletey jletey commented Jul 9, 2019

Closes #399

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #671 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #671   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c64e93...738f40c. Read the comment docs.

locness3
locness3 previously approved these changes Jul 9, 2019
@locness3
Copy link

locness3 commented Jul 9, 2019

Maybe rename to code-2 ?

@jletey
Copy link
Author

jletey commented Jul 10, 2019

Sure @locness3 ... but didn't @polys say in #399 that it should be called code-slash?

@locness3
Copy link

idk

@jletey
Copy link
Author

jletey commented Jul 11, 2019

ok @locness3 ... I will rename to code-2

Copy link

@locness3 locness3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should rename your PR as well.

@jletey jletey changed the title Add code-slash icon Add code-2 icon Jul 11, 2019
@polys
Copy link

polys commented Jul 11, 2019

Sure @locness3 ... but didn't @polys say in #399 that it should be called code-slash?

code-slash was just an initial suggestion; I don't really have a preference tbh 😀

Many thanks again!

@jletey
Copy link
Author

jletey commented Jul 12, 2019

@polys You are absolutely welcome! Let's stick with code-2 for now, but then again, it's really up to @colebemis to decide!

@jletey jletey changed the title Add code-2 icon feat: Add code-2 icon Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Request: Code with Forward Slash
3 participants