Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add divide icons #568

Merged
merged 3 commits into from Apr 4, 2020
Merged

feat: Add divide icons #568

merged 3 commits into from Apr 4, 2020

Conversation

csandman
Copy link
Contributor

@csandman csandman commented Apr 2, 2019

Added 3 division icons (also knows as an obelus). One by itself, one with a circle around it, and one with a square around it. These are meant to compliment the plus, minus, and x icons and fill out the set of math icons.

Screenshot 2019-04-01 21 13 06

The shapes are composed the same way as they are in the other math icons, using 1px lines for the points.

Closes #263

Added 3 division icons (also knows as an obelus).  One by itself, one with a circle around it, and one with a square around it.  These are meant to compliment plus, minus, and x icons.
@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #568 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #568   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
  Branches         3         3           
=========================================
  Hits            34        34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca4f12...a29060e. Read the comment docs.

@locness3 locness3 mentioned this pull request Apr 2, 2019
@colebemis
Copy link
Member

@csandman These look great! Thanks for opening a PR 🎉

My only feedback is that the dots on the divide icon might be a little small relative to the rest of the icon:

image

Could you try a version that uses a larger circle similar to the percent icon?

image

@csandman
Copy link
Contributor Author

divide

@colebemis Sorry I saw your comment so late! I gave it a shot, is this what you were thinking of?

The main reason I avoided this is because I felt that the circles were a bit too large but its up to you.

@mittalyashu
Copy link
Contributor

@csandman If you zoom out the divide icon looks perfect with bigger dots.

@ElForastero
Copy link

ElForastero commented Feb 29, 2020

Yeah, it looks a little bit thin compared to other icons.

But I still love it 😉

image

@csandman
Copy link
Contributor Author

csandman commented Mar 3, 2020

I know this is rather old, but I never pushed my change with the change requested by @colebemis

Anyway, now I have so feel free to merge if you like the change!

Here is what all 3 icons look like in context of the other icons:
Frame 1

Copy link
Member

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @csandman! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Request: divide
5 participants