Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add half-star icons #642

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jletey
Copy link

@jletey jletey commented Jun 29, 2019

Closes #452

@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #642 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #642   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c64e93...feb9952. Read the comment docs.

Copy link

@locness3 locness3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing the filled rectangle on second icon, putting the svg attributes into the svg tag, and formatting it like other icons ?

@jletey
Copy link
Author

jletey commented Jun 29, 2019

@locness3 Like this? I have removed the background and formatted!

@jletey jletey changed the title Add half-star icons feat: Add half-star icons Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: half-star
2 participants