Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon request: half-star #452

Open
deltavin opened this issue Jun 22, 2018 · 3 comments · May be fixed by #642
Open

Icon request: half-star #452

deltavin opened this issue Jun 22, 2018 · 3 comments · May be fixed by #642

Comments

@deltavin
Copy link

Icon name: half-star
Use case: For example, for 3.5 stars, one can include 3 star icons and 1 half-star icon
Example: https://fontawesome.com/icons/star-half?style=solid&from=io

@jletey
Copy link

jletey commented Jun 28, 2019

@locness3 @colebemis @deltavin How does this look? I think we should go with the half-star (left) icon!

@locness3
Copy link

@locness3 @colebemis @deltavin How does this look? I think we should go with the half-star (left) icon

Perfect! But maybe go with both instead of just the left, for right-to-left languages or other use cases ?

@jletey
Copy link

jletey commented Jun 29, 2019

Perfect! But maybe go with both instead of just the left, for right-to-left languages or other use cases ?

@locness3 I feel like that is a good reason for adding both ... it makes sense! I'm creating a PR now!

jletey added a commit to jletey/feather that referenced this issue Jun 29, 2019
@jletey jletey linked a pull request Jun 29, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants