Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add icon high-definition #659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feature: Add icon high-definition #659

wants to merge 1 commit into from

Conversation

ahtohbi4
Copy link
Contributor

@ahtohbi4 ahtohbi4 commented Jul 3, 2019

Closes #557

@codecov
Copy link

codecov bot commented Jul 3, 2019 •
edited

Codecov Report

Merging #659 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #659   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c64e93...febf875. Read the comment docs.

locness3
locness3 reviewed Jul 3, 2019
View reviewed changes
Copy link

@locness3 locness3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Myabe rename to HD

@ahtohbi4
Copy link
Contributor Author

ahtohbi4 commented Jul 3, 2019

Myabe rename to HD

Why not? Done.

@locness3
Copy link

locness3 commented Jul 3, 2019

Excuse me, but what is git force-pushing ?

@ahtohbi4
Copy link
Contributor Author

ahtohbi4 commented Jul 3, 2019

By the force-push I am rewriting my previous commit for clean Git-history (one feature - one commit).

@locness3
Copy link

locness3 commented Jul 3, 2019

Thanks for the tip 😉

MarcelloTheArcane
MarcelloTheArcane approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@MarcelloTheArcane MarcelloTheArcane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericfennis
Copy link

ericfennis commented Jun 23, 2020 •
edited

@ahtohbi4 Nice icon do you mind if we use your icon in @featherity, or maybe you want to open a PR by yourself.

@Andreto Andreto mentioned this pull request Oct 31, 2020
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelloTheArcane MarcelloTheArcane MarcelloTheArcane approved these changes

@locness3 locness3 locness3 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon Request: HD icon
4 participants
@ahtohbi4 @locness3 @ericfennis @MarcelloTheArcane